[GitHub] [superset] rasta-rocket commented on a change in pull request #14305: fix(views/core): iteration over None type

[GitBox <gi...@apache.org>]

rasta-rocket commented on a change in pull request #14305:
URL: https://github.com/apache/superset/pull/14305#discussion_r751027097



##########
File path: superset/views/core.py
##########
@@ -959,7 +959,7 @@ def save_or_overwrite_slice(
             slc = Slice(owners=[g.user] if g.user else [])
 
         form_data["adhoc_filters"] = self.remove_extra_filters(
-            form_data.get("adhoc_filters", [])
+            (form_data.get("adhoc_filters", []) or [])

Review comment:
       I don't really remember why I did that :sweat_smile:
   But agree :+1:




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org