You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Rhett Sutphin (JIRA)" <ji...@apache.org> on 2010/06/11 05:35:12 UTC

[jira] Created: (BUILDR-454) Definition-level parent-child references-by-name fail in 1.4.0 but not in 1.3.5

Definition-level parent-child references-by-name fail in 1.4.0 but not in 1.3.5
-------------------------------------------------------------------------------

                 Key: BUILDR-454
                 URL: https://issues.apache.org/jira/browse/BUILDR-454
             Project: Buildr
          Issue Type: Bug
          Components: Core features
    Affects Versions: 1.4
         Environment: OS X 10.6.3, JRuby 1.4.0 (but it shouldn't matter)
            Reporter: Rhett Sutphin


A buildfile like this one:

define "root" do
  define "child" do
    puts project('root')._('foo.resource')
  end
end

will work fine on buildr 1.3.5.  However, it fails with a circular dependency error on 1.4.0 RC4:

RuntimeError : Circular dependency detected: TOP => root => root:child => root
/private/tmp/buildr-problem/buildfile:3

I don't think this need block the release because the following workaround succeeds in both:

define "root" do
  define "child" do
    puts project.parent._('foo.resource')
  end
end


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (BUILDR-454) Definition-level parent-child references-by-name fail in 1.4.0 but not in 1.3.5

Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878290#action_12878290 ] 

Antoine Toulme commented on BUILDR-454:
---------------------------------------

This is occurring with Apache ODE. Adding this as a spec.

> Definition-level parent-child references-by-name fail in 1.4.0 but not in 1.3.5
> -------------------------------------------------------------------------------
>
>                 Key: BUILDR-454
>                 URL: https://issues.apache.org/jira/browse/BUILDR-454
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.4
>         Environment: OS X 10.6.3, JRuby 1.4.0 (but it shouldn't matter)
>            Reporter: Rhett Sutphin
>
> A buildfile like this one:
> define "root" do
>   define "child" do
>     puts project('root')._('foo.resource')
>   end
> end
> will work fine on buildr 1.3.5.  However, it fails with a circular dependency error on 1.4.0 RC4:
> RuntimeError : Circular dependency detected: TOP => root => root:child => root
> /private/tmp/buildr-problem/buildfile:3
> I don't think this need block the release because the following workaround succeeds in both:
> define "root" do
>   define "child" do
>     puts project.parent._('foo.resource')
>   end
> end

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (BUILDR-454) Definition-level parent-child references-by-name fail in 1.4.0 but not in 1.3.5

Posted by "Pepijn Van Eeckhoudt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Pepijn Van Eeckhoudt updated BUILDR-454:
----------------------------------------

    Attachment: circular_project_deps.patch

The attached patch adds the described case as a spec and resolves the problem.
I've added a defined? method to Project. A project is considered defined when its definition has been executed. The defined state of sub projects is undefined (i.e., may be true or false).

The contract of Project.project is loosened slightly by this change.

Documentation should still be updated, but I would like to an external review of this change before I put more effort into it.

> Definition-level parent-child references-by-name fail in 1.4.0 but not in 1.3.5
> -------------------------------------------------------------------------------
>
>                 Key: BUILDR-454
>                 URL: https://issues.apache.org/jira/browse/BUILDR-454
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.4
>         Environment: OS X 10.6.3, JRuby 1.4.0 (but it shouldn't matter)
>            Reporter: Rhett Sutphin
>         Attachments: circular_project_deps.patch
>
>
> A buildfile like this one:
> define "root" do
>   define "child" do
>     puts project('root')._('foo.resource')
>   end
> end
> will work fine on buildr 1.3.5.  However, it fails with a circular dependency error on 1.4.0 RC4:
> RuntimeError : Circular dependency detected: TOP => root => root:child => root
> /private/tmp/buildr-problem/buildfile:3
> I don't think this need block the release because the following workaround succeeds in both:
> define "root" do
>   define "child" do
>     puts project.parent._('foo.resource')
>   end
> end

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.