[PR] Revert "pthread_mutex:add deadlock assert" [nuttx]

["anchao (via GitHub)" <gi...@apache.org>]

anchao opened a new pull request, #13568:
URL: https://github.com/apache/nuttx/pull/13568

   ## Summary
   
   Revert "pthread_mutex:add deadlock assert"
   
   EDEADLK alreay checked in:
   https://github.com/apache/nuttx/blob/master/sched/pthread/pthread_mutextimedlock.c#L112-L127
   https://github.com/apache/nuttx/blob/master/sched/pthread/pthread_mutex.c#L195-L201
   
   This reverts commit 112cc083d30047b160fbeda753a26b88362cdf70.
   
   Signed-off-by: chao an <an...@lixiang.com>
   
   
   ## Impact
   
   N/A
   
   ## Testing
   
   ci-check
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "pthread_mutex:add deadlock assert" [nuttx]

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 merged PR #13568:
URL: https://github.com/apache/nuttx/pull/13568


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Revert "pthread_mutex:add deadlock assert" [nuttx]

["nuttxpr (via GitHub)" <gi...@apache.org>]

nuttxpr commented on PR #13568:
URL: https://github.com/apache/nuttx/pull/13568#issuecomment-2367074470

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   The PR does not meet the NuttX requirements fully. 
   
   **Here's why and how to improve it:**
   
   * **Summary:**
       * While it mentions the "what" (reverting a deadlock assert), it lacks a clear explanation of **why** the original change is being reverted.  Was it incorrect, redundant, causing issues? 
       * Be explicit about the functional area – is it just the pthread mutex implementation?
   * **Impact:**
       *  "N/A" is rarely fully accurate. Even a revert can have subtle impacts.  Consider:
           * **Compatibility:** Did the reverted change introduce any behavior that, while potentially buggy, some code might have relied on?
           * **Performance:**  Could removing the assert, even if redundant, have a minor performance impact (likely negligible, but worth mentioning if measurable)?
   * **Testing:**
       * "ci-check" is not sufficient. While CI is essential, a PR needs evidence of manual testing relevant to the change:
           * **What specific tests were run?** Ideally, provide commands or test names.
           * **Logs are missing.** Include both "before" and "after" logs to demonstrate the change's effect.
   
   **In short:**  The PR needs more context and explicit testing details to be considered complete against the NuttX requirements. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org