You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/20 12:52:20 UTC
[GitHub] [spark] MaxGekk opened a new pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
MaxGekk opened a new pull request #34049:
URL: https://github.com/apache/spark/pull/34049
### What changes were proposed in this pull request?
In the PR, I propose to modify `StructType` to support merging of ANSI interval types with different fields.
### Why are the changes needed?
This will allow merging of schemas from different datasource files.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Added new test to `StructTypeSuite`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-922899730
@sarutak @beliefer @AngersZhuuuu @Peng-Lei @cloud-fan Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
sarutak commented on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-922951358
With this change, `UNION` can also merge two different day-time interval types or year-month interval types right? If so, is it ANSI compliant behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-922950835
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47962/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-923707297
Merging to master/3.2. Thank you, @sarutak for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-922991766
> If so, is it ANSI compliant behavior?
I think it is, the standard says:
"
... If two year-month intervals have **different interval precisions**, they are, for the purpose of any operations between them, effectively converted to the same precision by appending new <primary datetime field>s to either the most significant end of one interval, the least significant end of one interval, or both.
... There are two classes of intervals. One class, called year-month intervals, has an express or implied **datetime precision** that includes no fields other than YEAR and MONTH ...
"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-922952580
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47962/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-923150545
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143453/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-922904926
**[Test build #143453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143453/testReport)** for PR 34049 at commit [`cd39508`](https://github.com/apache/spark/commit/cd3950805500196e848bb6f18935b7b6ad258fbf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-922904926
**[Test build #143453 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143453/testReport)** for PR 34049 at commit [`cd39508`](https://github.com/apache/spark/commit/cd3950805500196e848bb6f18935b7b6ad258fbf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-923150545
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143453/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-923136083
**[Test build #143453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143453/testReport)** for PR 34049 at commit [`cd39508`](https://github.com/apache/spark/commit/cd3950805500196e848bb6f18935b7b6ad258fbf).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-922943149
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47962/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #34049:
URL: https://github.com/apache/spark/pull/34049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34049: [SPARK-36807][SQL] Merge ANSI interval types to a tightest common type
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34049:
URL: https://github.com/apache/spark/pull/34049#issuecomment-922952580
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47962/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org