You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/11/19 21:22:07 UTC

Review Request 40498: Used factory method to create HDFS client.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40498/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.


Bugs: MESOS-3951
    https://issues.apache.org/jira/browse/MESOS-3951


Repository: mesos


Description
-------

Used factory method to create HDFS client.


Diffs
-----

  src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
  src/hdfs/hdfs.hpp 6604938e8ca1962db1f0159d175f52fd5c03dd3c 
  src/hdfs/hdfs.cpp PRE-CREATION 
  src/launcher/fetcher.cpp 7ad3206c31c47b7d1ae9f89c9e9347831aa3ea39 
  src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 

Diff: https://reviews.apache.org/r/40498/diff/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 40498: Used factory method to create HDFS client.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40498/#review107410
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Nov. 19, 2015, 8:22 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40498/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 8:22 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3951
>     https://issues.apache.org/jira/browse/MESOS-3951
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used factory method to create HDFS client.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
>   src/hdfs/hdfs.hpp 6604938e8ca1962db1f0159d175f52fd5c03dd3c 
>   src/hdfs/hdfs.cpp PRE-CREATION 
>   src/launcher/fetcher.cpp 7ad3206c31c47b7d1ae9f89c9e9347831aa3ea39 
>   src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 
> 
> Diff: https://reviews.apache.org/r/40498/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>