You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@cn.ibm.com> on 2016/11/30 09:57:09 UTC
Review Request 54200: Updated H-DRF allocator to handle multi-role
framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54200/
-----------------------------------------------------------
Review request for mesos, Guangya Liu and Qiang Zhang.
Bugs: MESOS-6635
https://issues.apache.org/jira/browse/MESOS-6635
Repository: mesos
Description
-------
WIP patch to add support to allocator for multi-role frameworks.
Currently it implements first two items mentioned in MESOS-6635.
Diffs
-----
src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4
src/common/protobuf_utils.cpp 56e16648ae138ed6da40811144b721cd82b5f8a0
src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013
src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e
src/tests/hierarchical_allocator_tests.cpp 3b0eb75882102f44b6f490789bc48a638437a2d9
Diff: https://reviews.apache.org/r/54200/diff/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 54200: Added a helper function to get roles from
FrameworkInfo.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54200/#review158386
-----------------------------------------------------------
Fix it, then Ship it!
Can you follow up with a unit test for this function?
src/common/protobuf_utils.hpp (lines 204 - 209)
<https://reviews.apache.org/r/54200/#comment229145>
Looks like you need a set include now?
- Benjamin Mahler
On Dec. 7, 2016, 8:59 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54200/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 8:59 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang.
>
>
> Bugs: MESOS-6635
> https://issues.apache.org/jira/browse/MESOS-6635
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The function returns a set<string> containing all roles in a
> multi-role FrameworkInfo. For single-role FrameworkInfo, there
> is only one element in the set.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4
> src/common/protobuf_utils.cpp 56e16648ae138ed6da40811144b721cd82b5f8a0
>
> Diff: https://reviews.apache.org/r/54200/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54200: Added a helper function to get roles from
FrameworkInfo.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54200/#review158330
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54359, 54360, 54361, 54365, 54200]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 7, 2016, 8:59 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54200/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 8:59 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang.
>
>
> Bugs: MESOS-6635
> https://issues.apache.org/jira/browse/MESOS-6635
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The function returns a set<string> containing all roles in a
> multi-role FrameworkInfo. For single-role FrameworkInfo, there
> is only one element in the set.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4
> src/common/protobuf_utils.cpp 56e16648ae138ed6da40811144b721cd82b5f8a0
>
> Diff: https://reviews.apache.org/r/54200/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 54200: Added a helper function to get roles from
FrameworkInfo.
Posted by Jay Guo <gu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54200/
-----------------------------------------------------------
(Updated Dec. 7, 2016, 4:59 p.m.)
Review request for mesos, Benjamin Mahler, Guangya Liu, and Qian Zhang.
Changes
-------
This is a helper function to facilitate MESOS-6635. Actual functional changes of allocator will be submitted in separate patches from BenM.
Summary (updated)
-----------------
Added a helper function to get roles from FrameworkInfo.
Bugs: MESOS-6635
https://issues.apache.org/jira/browse/MESOS-6635
Repository: mesos
Description (updated)
-------
The function returns a set<string> containing all roles in a
multi-role FrameworkInfo. For single-role FrameworkInfo, there
is only one element in the set.
Diffs (updated)
-----
src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4
src/common/protobuf_utils.cpp 56e16648ae138ed6da40811144b721cd82b5f8a0
Diff: https://reviews.apache.org/r/54200/diff/
Testing (updated)
-------
Thanks,
Jay Guo
Re: Review Request 54200: Updated H-DRF allocator to handle multi-role
framework.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54200/#review157399
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54061, 54062, 54197, 54198, 54199, 54200]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Nov. 30, 2016, 9:57 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54200/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2016, 9:57 a.m.)
>
>
> Review request for mesos, Guangya Liu and Qiang Zhang.
>
>
> Bugs: MESOS-6635
> https://issues.apache.org/jira/browse/MESOS-6635
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP patch to add support to allocator for multi-role frameworks.
> Currently it implements first two items mentioned in MESOS-6635.
>
>
> Diffs
> -----
>
> src/common/protobuf_utils.hpp 80c66c4f7d52fc184e7553d173195ba7714971d4
> src/common/protobuf_utils.cpp 56e16648ae138ed6da40811144b721cd82b5f8a0
> src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013
> src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e
> src/tests/hierarchical_allocator_tests.cpp 3b0eb75882102f44b6f490789bc48a638437a2d9
>
> Diff: https://reviews.apache.org/r/54200/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>