You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Liangyu Zhao via Review Board <no...@reviews.apache.org> on 2018/08/30 22:32:20 UTC
Review Request 68582: Windows: Add `WclayerBackend` to provision
Docker image.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68582/
-----------------------------------------------------------
Review request for mesos, Akash Gupta and Andrew Schwartzmeyer.
Repository: mesos
Description
-------
Implemented `WclayerBackend` using `wclayer` from `microsoft/hcsshim`
to provision Docker image on Windows.
Diffs
-----
src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8
src/slave/containerizer/mesos/provisioner/backend.cpp 157967f75011bdaeededd218ed6c734bd00c1d1d
src/slave/containerizer/mesos/provisioner/backends/wclayer.hpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/backends/wclayer.cpp PRE-CREATION
src/slave/containerizer/mesos/provisioner/constants.hpp ab488eb3343cf2ad5747e374995e76d26d4eb879
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2
src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6
src/slave/containerizer/mesos/provisioner/provisioner.cpp ac402fbead81e4b356cb35cea08a00049002e870
Diff: https://reviews.apache.org/r/68582/diff/1/
Testing
-------
Thanks,
Liangyu Zhao
Re: Review Request 68582: Windows: Add `WclayerBackend` to provision
Docker image.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68582/#review208155
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68581', '68582']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2267/mesos-review-68582
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2267/mesos-review-68582/logs/mesos-tests.log):
```
I0830 23:36:41.759671 25552 executor.cpp:693] Forked command at 32660
I0830 23:36:41.790634 34800 exec.cpp:445] Executor asked to shutdown
I0830 23:36:41.791852 25552 executor.cpp:182] Received SHUTDOWN event
I0830 23:36:41.791852 25552 executor.cpp:796] Shutting down
I0830 23:36:41.792639 25552 executor.cpp:909] Sending SIGTERM to process tree at pid 32-496f-91ab-58dd0a016de4-S0 at slave(459)@192.10.1.6:50936 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0830 23:36:41.794631 27896 master.cpp:1251] Agent f9d8e898-62de-496f-91ab-58dd0a016de4-S0 at slave(459)@192.10.1.6:50936 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0830 23:36:41.794631 27896 master.cpp:3267] Disconnecting agent f9d8e898-62de-496f-91ab-58dd0a016de4-S0 at slave(459)@192.10.1.6:50936 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0830 23:36:41.794631 27896 master.cpp:3286] Deactivating agent f9d8e898-62de-496f-91ab-58dd0a016de4-S0 at slave(459)@192.10.1.6:50936 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0830 23:36:41.795646 26976 hierarchical.cpp:359] Removed framework f9d8e898-62de-496f-91ab-58dd0a016de4-0000
I0830 23:36:41.795646 26976 hierarchical.cpp:795] Agent f9d8e898-62de-496f-91ab-58dd0a016de4-S0 deactivated
I0830 23:36:41.795646 32936 containerizer.cpp:2429] Destroying container a055a46f-[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (587 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (607 ms total)
[----------] Global test environment tear-down
[==========] 1046 tests from 103 test cases ran. (489529 ms total)
[ PASSED ] 1045 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
1 FAILED TEST
YOU HAVE 229 DISABLED TESTS
422e-4879-befe-367299e40a3e in RUNNING state
I0830 23:36:41.795646 32936 containerizer.cpp:3043] Transitioning the state of container a055a46f-422e-4879-befe-367299e40a3e from RUNNING to DESTROYING
I0830 23:36:41.796653 32936 launcher.cpp:166] Asked to destroy container a055a46f-422e-4879-befe-367299e40a3e
I0830 23:36:41.801622 33872 containerizer.cpp:2882] Container a055a46f-422e-4879-befe-367299e40a3e has exited
I0830 23:36:41.831648 33432 master.cpp:1093] Master terminating
I0830 23:36:41.832628 31900 hierarchical.cpp:637] Removed agent f9d8e898-62de-496f-91ab-58dd0a016de4-S0
I0830 23:36:42.205652 33700 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Aug. 30, 2018, 3:32 p.m., Liangyu Zhao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68582/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 3:32 p.m.)
>
>
> Review request for mesos, Akash Gupta and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented `WclayerBackend` using `wclayer` from `microsoft/hcsshim`
> to provision Docker image on Windows.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8
> src/slave/containerizer/mesos/provisioner/backend.cpp 157967f75011bdaeededd218ed6c734bd00c1d1d
> src/slave/containerizer/mesos/provisioner/backends/wclayer.hpp PRE-CREATION
> src/slave/containerizer/mesos/provisioner/backends/wclayer.cpp PRE-CREATION
> src/slave/containerizer/mesos/provisioner/constants.hpp ab488eb3343cf2ad5747e374995e76d26d4eb879
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6
> src/slave/containerizer/mesos/provisioner/provisioner.cpp ac402fbead81e4b356cb35cea08a00049002e870
>
>
> Diff: https://reviews.apache.org/r/68582/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Liangyu Zhao
>
>
Re: Review Request 68582: Windows: Add `WclayerBackend` to provision
Docker image.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68582/#review208214
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68581, 68582]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 30, 2018, 10:32 p.m., Liangyu Zhao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68582/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 10:32 p.m.)
>
>
> Review request for mesos, Akash Gupta and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented `WclayerBackend` using `wclayer` from `microsoft/hcsshim`
> to provision Docker image on Windows.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8
> src/slave/containerizer/mesos/provisioner/backend.cpp 157967f75011bdaeededd218ed6c734bd00c1d1d
> src/slave/containerizer/mesos/provisioner/backends/wclayer.hpp PRE-CREATION
> src/slave/containerizer/mesos/provisioner/backends/wclayer.cpp PRE-CREATION
> src/slave/containerizer/mesos/provisioner/constants.hpp ab488eb3343cf2ad5747e374995e76d26d4eb879
> src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp a5683e3fe15dd35596122fcc0c580ae9d3adf7f2
> src/slave/containerizer/mesos/provisioner/docker/store.cpp 60507aa1b7951666ed758d1b3800eddd67ba7be6
> src/slave/containerizer/mesos/provisioner/provisioner.cpp ac402fbead81e4b356cb35cea08a00049002e870
>
>
> Diff: https://reviews.apache.org/r/68582/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Liangyu Zhao
>
>