[GitHub] [shardingsphere] sandynz commented on a change in pull request #14832: Check mode config in DistSQL handler on demand but not on getting scaling API from PipelineAPIFactory

[GitBox <gi...@apache.org>]

sandynz commented on a change in pull request #14832:
URL: https://github.com/apache/shardingsphere/pull/14832#discussion_r785817722



##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-distsql/shardingsphere-sharding-distsql-handler/src/main/java/org/apache/shardingsphere/scaling/distsql/handler/CheckScalingQueryResultSet.java
##########
@@ -36,16 +37,18 @@
  */
 public final class CheckScalingQueryResultSet implements DistSQLResultSet {
     
+    private static final RuleAlteredJobAPI RULE_ALTERED_JOB_API = PipelineJobAPIFactory.getRuleAlteredJobAPI();

Review comment:
       Keep the same name as `RuleAlteredJobAPI` interface, it fits Java code conduct.
   
   And `RuleAlteredJobAPI` might be renamed later, it need more consideration and discussion.
   
   Any suggestion on the naming?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org