You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ashutosh Mestry <am...@hortonworks.com> on 2018/10/16 04:52:54 UTC
Review Request 69038: SET/Optional Multiplicity Calculation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69038/
-----------------------------------------------------------
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-2922
https://issues.apache.org/jira/browse/ATLAS-2922
Repository: atlas
Description
-------
**Approach**
- New condition added.
- Refactoring, removal of duplicate code.
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 78df622d3dcec6e07b5abdc7ef0e5520ede53c2e
intg/src/test/java/org/apache/atlas/type/TestMultiplicity.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java 3c21465a34007173ef1ef0239c03133775722676
Diff: https://reviews.apache.org/r/69038/diff/1/
Testing
-------
**Unit tests**
New test added.
**Additional tests**
Using CURL calls. Please see JIRA.
Thanks,
Ashutosh Mestry
Re: Review Request 69038: SET/Optional Multiplicity Calculation
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69038/#review209590
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java
Lines 498 (patched)
<https://reviews.apache.org/r/69038/#comment294117>
It seems 'lower' will be set '1' for LIST & SET - even if this is an optional attribute. How is entity validation impacted by this change? i.e create/update of an entity with an empty value for LIST/SET type attribute.
- Madhan Neethiraj
On Oct. 16, 2018, 4:52 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69038/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2018, 4:52 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2922
> https://issues.apache.org/jira/browse/ATLAS-2922
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> - New condition added.
> - Refactoring, removal of duplicate code.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 78df622d3dcec6e07b5abdc7ef0e5520ede53c2e
> intg/src/test/java/org/apache/atlas/type/TestMultiplicity.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java 3c21465a34007173ef1ef0239c03133775722676
>
>
> Diff: https://reviews.apache.org/r/69038/diff/1/
>
>
> Testing
> -------
>
> **Unit tests**
> New test added.
>
> **Additional tests**
> Using CURL calls. Please see JIRA.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 69038: SET/Optional Multiplicity Calculation
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69038/#review209593
-----------------------------------------------------------
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java
Line 494 (original), 500 (patched)
<https://reviews.apache.org/r/69038/#comment294123>
line #500 and #502 is not reachable, since cardinality will always be list or set in 497.
- Sarath Subramanian
On Oct. 15, 2018, 9:52 p.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69038/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2018, 9:52 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2922
> https://issues.apache.org/jira/browse/ATLAS-2922
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> - New condition added.
> - Refactoring, removal of duplicate code.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 78df622d3dcec6e07b5abdc7ef0e5520ede53c2e
> intg/src/test/java/org/apache/atlas/type/TestMultiplicity.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java 3c21465a34007173ef1ef0239c03133775722676
>
>
> Diff: https://reviews.apache.org/r/69038/diff/2/
>
>
> Testing
> -------
>
> **Unit tests**
> New test added.
>
> **Additional tests**
> Using CURL calls. Please see JIRA.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 69038: SET/Optional Multiplicity Calculation
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69038/#review209596
-----------------------------------------------------------
Fix it, then Ship it!
intg/src/main/java/org/apache/atlas/v1/model/typedef/Multiplicity.java
Lines 57 (patched)
<https://reviews.apache.org/r/69038/#comment294125>
SET_OPTIONAL - seems unused. Please review and remove if not used.
- Madhan Neethiraj
On Oct. 16, 2018, 6:19 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69038/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2018, 6:19 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2922
> https://issues.apache.org/jira/browse/ATLAS-2922
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> - New condition added.
> - Refactoring, removal of duplicate code.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 78df622d3dcec6e07b5abdc7ef0e5520ede53c2e
> intg/src/main/java/org/apache/atlas/v1/model/typedef/Multiplicity.java 6da4ce58d02ecedc81516898cfb4ccc87d92abd6
> intg/src/test/java/org/apache/atlas/type/TestMultiplicity.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java 3c21465a34007173ef1ef0239c03133775722676
>
>
> Diff: https://reviews.apache.org/r/69038/diff/3/
>
>
> Testing
> -------
>
> **Unit tests**
> New test added.
>
> **Additional tests**
> Using CURL calls. Please see JIRA.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 69038: SET/Optional Multiplicity Calculation
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69038/#review209641
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Oct. 16, 2018, 9:25 a.m., Ashutosh Mestry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69038/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2018, 9:25 a.m.)
>
>
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-2922
> https://issues.apache.org/jira/browse/ATLAS-2922
>
>
> Repository: atlas
>
>
> Description
> -------
>
> **Approach**
>
> - New condition added.
> - Refactoring, removal of duplicate code.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 78df622d3dcec6e07b5abdc7ef0e5520ede53c2e
> intg/src/main/java/org/apache/atlas/v1/model/typedef/Multiplicity.java 6da4ce58d02ecedc81516898cfb4ccc87d92abd6
> intg/src/test/java/org/apache/atlas/type/TestMultiplicity.java PRE-CREATION
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java 3c21465a34007173ef1ef0239c03133775722676
>
>
> Diff: https://reviews.apache.org/r/69038/diff/4/
>
>
> Testing
> -------
>
> **Unit tests**
> New test added.
>
> **Additional tests**
> Using CURL calls. Please see JIRA.
>
>
> Thanks,
>
> Ashutosh Mestry
>
>
Re: Review Request 69038: SET/Optional Multiplicity Calculation
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69038/
-----------------------------------------------------------
(Updated Oct. 16, 2018, 4:25 p.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Updates include: Addressed review comments.
Bugs: ATLAS-2922
https://issues.apache.org/jira/browse/ATLAS-2922
Repository: atlas
Description
-------
**Approach**
- New condition added.
- Refactoring, removal of duplicate code.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 78df622d3dcec6e07b5abdc7ef0e5520ede53c2e
intg/src/main/java/org/apache/atlas/v1/model/typedef/Multiplicity.java 6da4ce58d02ecedc81516898cfb4ccc87d92abd6
intg/src/test/java/org/apache/atlas/type/TestMultiplicity.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java 3c21465a34007173ef1ef0239c03133775722676
Diff: https://reviews.apache.org/r/69038/diff/4/
Changes: https://reviews.apache.org/r/69038/diff/3-4/
Testing
-------
**Unit tests**
New test added.
**Additional tests**
Using CURL calls. Please see JIRA.
Thanks,
Ashutosh Mestry
Re: Review Request 69038: SET/Optional Multiplicity Calculation
Posted by Ashutosh Mestry <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69038/
-----------------------------------------------------------
(Updated Oct. 16, 2018, 6:19 a.m.)
Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
Updates include:
- Addressed review comments.
- Updated unit tests.
Bugs: ATLAS-2922
https://issues.apache.org/jira/browse/ATLAS-2922
Repository: atlas
Description
-------
**Approach**
- New condition added.
- Refactoring, removal of duplicate code.
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 78df622d3dcec6e07b5abdc7ef0e5520ede53c2e
intg/src/main/java/org/apache/atlas/v1/model/typedef/Multiplicity.java 6da4ce58d02ecedc81516898cfb4ccc87d92abd6
intg/src/test/java/org/apache/atlas/type/TestMultiplicity.java PRE-CREATION
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java 3c21465a34007173ef1ef0239c03133775722676
Diff: https://reviews.apache.org/r/69038/diff/3/
Changes: https://reviews.apache.org/r/69038/diff/2-3/
Testing
-------
**Unit tests**
New test added.
**Additional tests**
Using CURL calls. Please see JIRA.
Thanks,
Ashutosh Mestry