You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/03 07:35:56 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #31723: [SPARK-34604][PYTHON][TESTS] Use eventually in TaskContextTestsWithWorkerReuse.test_task_context_correct_with_python_worker_reuse

HyukjinKwon commented on a change in pull request #31723:
URL: https://github.com/apache/spark/pull/31723#discussion_r586178880



##########
File path: python/pyspark/tests/test_taskcontext.py
##########
@@ -282,6 +281,11 @@ def context(iterator):
         self.assertTrue(bps == (-1, -1))
         for pid in pids:
             self.assertTrue(pid in worker_pids)
+        return True
+
+    def test_task_context_correct_with_python_worker_reuse(self):
+        eventually(
+            self.check_task_context_correct_with_python_worker_reuse, catch_assertions=True)

Review comment:
       Sure sure 👌 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org