You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/11 18:34:55 UTC
[GitHub] codecov-io commented on issue #4651: [explore] proper filtering of
NULLs and ''
codecov-io commented on issue #4651: [explore] proper filtering of NULLs and ''
URL: https://github.com/apache/incubator-superset/pull/4651#issuecomment-374685460
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=h1) Report
> Merging [#4651](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/adf9ec0bb1943caa16b7da5515741c1f4905c0ea?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `76.62%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4651 +/- ##
==========================================
+ Coverage 72.29% 72.32% +0.02%
==========================================
Files 208 208
Lines 15522 15571 +49
Branches 1202 1209 +7
==========================================
+ Hits 11222 11261 +39
- Misses 4297 4307 +10
Partials 3 3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et/assets/javascripts/components/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvT25QYXN0ZVNlbGVjdC5qc3g=) | `93.18% <ø> (ø)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `78.44% <100%> (+0.02%)` | :arrow_up: |
| [superset/assets/javascripts/common.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbW1vbi5qcw==) | `40% <100%> (+40%)` | :arrow_up: |
| [.../assets/javascripts/components/AlteredSliceTag.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvQWx0ZXJlZFNsaWNlVGFnLmpzeA==) | `100% <100%> (ø)` | :arrow_up: |
| [superset/assets/javascripts/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L2NoYXJ0QWN0aW9uLmpz) | `52.52% <33.33%> (-0.6%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.1% <44.44%> (-0.99%)` | :arrow_down: |
| [superset/assets/javascripts/SqlLab/actions.js](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9hY3Rpb25zLmpz) | `72.44% <50%> (+0.12%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.14% <73.33%> (-0.48%)` | :arrow_down: |
| [...javascripts/explore/components/controls/Filter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXIuanN4) | `78.78% <75%> (-0.58%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.38% <86.95%> (-0.6%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/4651/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=footer). Last update [adf9ec0...004aac5](https://codecov.io/gh/apache/incubator-superset/pull/4651?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services