[GitHub] [beam] KonradJanica commented on a change in pull request #16385: [BEAM-13535] [Playground] add cancel execution button

[GitBox <gi...@apache.org>]

KonradJanica commented on a change in pull request #16385:
URL: https://github.com/apache/beam/pull/16385#discussion_r776559907



##########
File path: playground/frontend/lib/pages/playground/states/playground_state.dart
##########
@@ -141,6 +143,18 @@ class PlaygroundState with ChangeNotifier {
     }
   }
 
+  Future<void> cancelRun() async {
+    if (_runSubscription != null) {
+      _runSubscription?.cancel();

Review comment:
       Question mark is redundant.

##########
File path: playground/frontend/lib/modules/editor/repository/code_repository/run_code_result.dart
##########
@@ -58,17 +60,22 @@ class RunCodeResult {
       identical(this, other) ||
       other is RunCodeResult &&
           runtimeType == other.runtimeType &&
+          pipelineUuid == other.pipelineUuid &&
           status == other.status &&
           output == other.output &&
           log == other.log &&
           errorMessage == other.errorMessage;
 
   @override
   int get hashCode =>
-      status.hashCode ^ output.hashCode ^ log.hashCode ^ errorMessage.hashCode;
+      pipelineUuid.hashCode ^

Review comment:
       The recommended flutter way to calculate the hashCode is using the function `hashValues`. For more details, see https://api.flutter.dev/flutter/dart-ui/hashValues.html.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org