You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Julian Reschke <ju...@gmx.de> on 2017/04/20 13:43:34 UTC

OAK-6089 (maven plugin updates) and OAK-5664 (require Java 8), also: move to Maven 3.3.9?

Hi there,

in preparation of the switch to Java 8, I have updated lots of maven 
plugin dependencies and also explicitly required the use of Maven 3.2.1 
(this is the version we use in CI, and was apparently was also de facto 
required already).

I ran integration tests after each of these changes, but can't promise 
that I didn't break something not covered by the tests.

There are a few recommended plugin updates still to be done:

> [INFO]   org.apache.felix:maven-scr-plugin .................. 1.21.0 -> 1.24.0
> [INFO]   org.springframework.boot:spring-boot-maven-plugin  1.3.8.RELEASE -> 1.5.2.RELEASE

...but these require more changes, and I'll open separate tickets for these.

With this done, we can switch to Java 8 (as required language level); 
I'll do that later today.

That said, while at it, we could go even further and require Maven 3.3.9 
- I've been building past branches of Jackrabbit and Oak with it, and 
haven't noticed any problems. Feedback on this would be appreciated.

Best regards, Julian

Re: OAK-6089 (maven plugin updates) and OAK-5664 (require Java 8), also: move to Maven 3.3.9?

Posted by Robert Munteanu <ro...@apache.org>.
Hi Julian,

On Thu, 2017-04-20 at 15:43 +0200, Julian Reschke wrote:
> Hi there,
> 
> in preparation of the switch to Java 8, I have updated lots of maven�
> plugin dependencies and also explicitly required the use of Maven
> 3.2.1�
> (this is the version we use in CI, and was apparently was also de
> facto�
> required already).
> 
> I ran integration tests after each of these changes, but can't
> promise�
> that I didn't break something not covered by the tests.
> 
> There are a few recommended plugin updates still to be done:
> 
> > [INFO]���org.apache.felix:maven-scr-plugin ..................
> > 1.21.0 -> 1.24.0
> > [INFO]���org.springframework.boot:spring-boot-maven-
> > plugin��1.3.8.RELEASE -> 1.5.2.RELEASE
> 
> ...but these require more changes, and I'll open separate tickets for
> these.
> 
> With this done, we can switch to Java 8 (as required language
> level);�
> I'll do that later today.
> 
> That said, while at it, we could go even further and require Maven
> 3.3.9�
> - I've been building past branches of Jackrabbit and Oak with it,
> and�
> haven't noticed any problems. Feedback on this would be appreciated.

I am not aware of any breaking changes in Maven 3.3.9 and I have been
using it since it's been released.

In my opinion we can be a bit more relaxed about Maven version
requirements since they are involved in building Oak, not running Oak.

It's usually pain-free to update to a newer version of Maven or, if
really needed, to install an additional one next to the old one.

Robert