You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by karanmehta93 <gi...@git.apache.org> on 2018/09/04 20:39:11 UTC

[GitHub] phoenix pull request #338: PHOENIX-4870 LoggingPhoenixConnection should log ...

Github user karanmehta93 commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/338#discussion_r215059097
  
    --- Diff: phoenix-core/src/main/java/org/apache/phoenix/jdbc/LoggingPhoenixStatement.java ---
    @@ -59,4 +70,17 @@ public ResultSet getGeneratedKeys() throws SQLException {
             return new LoggingPhoenixResultSet(super.getGeneratedKeys(), phoenixMetricsLog, this.sql);
         }
     
    +    private void loggingAutoCommitHelper() throws SQLException {
    +        Connection conn = this.getConnection();
    +
    +        if(stmt.getUpdateOperation().isMutation() && conn.getAutoCommit()){
    --- End diff --
    
    > In case of mutation, it directly executes executeMutation
    
    You can also provide a mutation through `execute()` method call.


---