You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/02 06:43:52 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #2757: [ISSUE-2741] getObject method in JDBC should return an Object

HTHou commented on a change in pull request #2757:
URL: https://github.com/apache/iotdb/pull/2757#discussion_r585299034



##########
File path: jdbc/src/test/java/org/apache/iotdb/jdbc/IoTDBJDBCResultSetTest.java
##########
@@ -233,6 +236,12 @@ public void testQuery() throws Exception {
               + "105,11.11,199,33333,11.11,\n"
               + "1000,1000.11,55555,22222,1000.11,\n"; // Note the LIMIT&OFFSET clause takes effect
       Assert.assertEquals(standard, resultStr.toString());
+      List<Object> standardObject = new ArrayList<>();
+      constructObjectList(standardObject);
+      Assert.assertEquals(standardObject.size(), resultObjectList.size());
+      for (int i = 0; i < standardObject.size(); i++) {
+        Assert.assertEquals(standardObject.get(i), resultObjectList.get(i));
+      }

Review comment:
       <img width="1113" alt="Screen Shot 2021-03-02 at 2 42 29 PM" src="https://user-images.githubusercontent.com/25913899/109608907-92382b00-7b65-11eb-9934-0333764cc1b2.png">
   
   If I change `result.getObject(i)` to `result.getString(i)`, the test failed....




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org