You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Lukas Majercak (JIRA)" <ji...@apache.org> on 2018/07/02 20:45:00 UTC
[jira] [Comment Edited] (HDFS-13714) Fix
TestNameNodePrunesMissingStorages test failures on Windows
[ https://issues.apache.org/jira/browse/HDFS-13714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16530423#comment-16530423 ]
Lukas Majercak edited comment on HDFS-13714 at 7/2/18 8:44 PM:
---------------------------------------------------------------
The rename used is standard Java. From docs:
{code:java}
Renames the file denoted by this abstract pathname.
*
* <p> Many aspects of the behavior of this method are inherently
* platform-dependent: The rename operation might not be able to move a
* file from one filesystem to another, it might not be atomic, and it
* might not succeed if a file with the destination abstract pathname
* already exists. The return value should always be checked to make sure
* that the rename operation was successful.{code}
Seems like this fails on Windows. Proposing to change to delete() followed by renameTo()
was (Author: lukmajercak):
The rename used is standard Java. From docs:
{code:java}
Renames the file denoted by this abstract pathname.
*
* <p> Many aspects of the behavior of this method are inherently
* platform-dependent: The rename operation might not be able to move a
* file from one filesystem to another, it might not be atomic, and it
* might not succeed if a file with the destination abstract pathname
* already exists. The return value should always be checked to make sure
* that the rename operation was successful.{code}
Seems like this fails on Windows. Proposing to change to delete() followed by renameTo()
> Fix TestNameNodePrunesMissingStorages test failures on Windows
> --------------------------------------------------------------
>
> Key: HDFS-13714
> URL: https://issues.apache.org/jira/browse/HDFS-13714
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs, namenode, test
> Affects Versions: 3.1.0, 2.9.1, 3.2.0
> Reporter: Lukas Majercak
> Assignee: Lukas Majercak
> Priority: Major
> Labels: windows
> Attachments: HDFS-13714.000.patch
>
>
> Failed here:
> https://builds.apache.org/job/hadoop-trunk-win/508/testReport/org.apache.hadoop.hdfs.server.blockmanagement/TestNameNodePrunesMissingStorages/testRenamingStorageIds/
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org