You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by yyqqing <gi...@git.apache.org> on 2017/07/05 03:07:06 UTC

[GitHub] incubator-weex pull request #493: * [android] fix bug that WXText lines cann...

GitHub user yyqqing opened a pull request:

    https://github.com/apache/incubator-weex/pull/493

    * [android] fix bug that WXText lines cannot be reset

    * [android] fix bug that WXText lines cannot be reset

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yyqqing/incubator-weex master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/493.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #493
    
----
commit 4cc6f30276a3295ee978e106e1ca89f9db2c32aa
Author: YangQing <ya...@yangqingmbp.local>
Date:   2017-07-05T02:55:09Z

    * [android] fix bug that WXText lines cannot be reset

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #493: * [android] fix bug that WXText lines cannot be r...

Posted by yyqqing <gi...@git.apache.org>.
Github user yyqqing commented on the issue:

    https://github.com/apache/incubator-weex/pull/493
  
     @luics , @sospartan Please review this, thx.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #493: * [android] fix bug that WXText lines cannot be r...

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/493
  
    
    <!--
      1 failure:  This PR modify SD...
      2 warning:  No Changelog chan..., This PR should up...
      1 messages
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>According to the blame info, we recommended @luics , @sospartan to be the reviewers.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #493: * [android] fix bug that WXText lines cannot be r...

Posted by misakuo <gi...@git.apache.org>.
Github user misakuo commented on the issue:

    https://github.com/apache/incubator-weex/pull/493
  
    Done. Thanks for your contribution


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #493: * [android] fix bug that WXText lines cannot be r...

Posted by sospartan <gi...@git.apache.org>.
Github user sospartan commented on the issue:

    https://github.com/apache/incubator-weex/pull/493
  
    @misakuo Merge this PR if the travis error is not related.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #493: * [android] fix bug that WXText lines cann...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/493


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---