You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/28 00:05:00 UTC
[jira] [Commented] (GEODE-3140) CI Failure:
FileSystemJUnitTest.testExport
[ https://issues.apache.org/jira/browse/GEODE-3140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065687#comment-16065687 ]
ASF GitHub Bot commented on GEODE-3140:
---------------------------------------
GitHub user DivineEnder opened a pull request:
https://github.com/apache/geode/pull/608
GEODE-3140: Removed DiskDirRule and replaced use with TemporaryFolder…
… rule
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DivineEnder/geode feature/GEODE-3140
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/608.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #608
----
commit 8e43d6139c13ad5de6355f34637d92af8e9d699e
Author: David Anuta <da...@gmail.com>
Date: 2017-06-28T00:00:00Z
GEODE-3140: Removed DiskDirRule and replaced use with TemporaryFolder rule
----
> CI Failure: FileSystemJUnitTest.testExport
> ------------------------------------------
>
> Key: GEODE-3140
> URL: https://issues.apache.org/jira/browse/GEODE-3140
> Project: Geode
> Issue Type: Bug
> Components: lucene
> Reporter: Jason Huynh
> Assignee: David Anuta
>
> A few travis ci runs have seen the following error:
> org.apache.geode.cache.lucene.internal.filesystem.FileSystemJUnitTest > testExport FAILED
> java.lang.RuntimeException: Could not delete disk dir: ./DiskDirRule-37255322000983
> Caused by:
> java.nio.file.NoSuchFileException: ./DiskDirRule-37255322000983
> We can either modify the existing disk dir to ignore FileNotFoundExceptions (we meant to delete the file anyways and if it is not there, do we really care if it's not found?)
> Or we can change out the DiskDir rule for the TemporaryFileRule.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)