You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Tom Bentley <tb...@redhat.com> on 2021/07/05 13:00:26 UTC
Re: [VOTE] KIP-707: The future of KafkaFuture
During code review Chia-Ping noticed that the `throws InterruptedException`
clause on the declaration of KafkaFuture#getNow() is not needed. We propose
to remove it. Note that removing it is not a source compatible change since
existing code which caught InterruptedException would get a compile error
about the exception not being thrown in the try block.
Please reply here if you want to discuss further, otherwise we'll assume
removing it is acceptable.
Kind regards,
Tom
On Tue, Apr 6, 2021 at 4:08 PM Tom Bentley <tb...@redhat.com> wrote:
> Hi,
>
> The vote passes with 4 binding +1s (Ismael, David Chia-Ping and Colin),
> and 1 non-binding +1 (Ryanne).
>
> Many thanks to those who commented and/or voted.
>
> Tom
>
> On Thu, Apr 1, 2021 at 8:21 PM Colin McCabe <cm...@apache.org> wrote:
>
>> +1 (binding). Thanks for the KIP.
>>
>> Colin
>>
>>
>> On Tue, Mar 30, 2021, at 20:36, Chia-Ping Tsai wrote:
>> > Thanks for this KIP. +1 (binding)
>> >
>> > On 2021/03/29 15:34:55, Tom Bentley <tb...@redhat.com> wrote:
>> > > Hi,
>> > >
>> > > I'd like to start a vote on KIP-707, which proposes to add
>> > > KafkaFuture.toCompletionStage(), deprecate KafkaFuture.Function and
>> make a
>> > > couple of other minor cosmetic changes.
>> > >
>> > >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-707%3A+The+future+of+KafkaFuture
>> > >
>> > > Many thanks,
>> > >
>> > > Tom
>> > >
>> >
>>
>>
Re: [VOTE] KIP-707: The future of KafkaFuture
Posted by Tom Bentley <tb...@redhat.com>.
Hi Colin,
Sorry, I probably should've updated the thread, but that's indeed what we
did.
Cheers,
Tom
On Mon, Aug 2, 2021 at 12:25 AM Colin McCabe <cm...@apache.org> wrote:
> Hi Tom,
>
> We don't want to break source code compatibility, so I think we should
> avoid removing this exception.
>
> best,
> Colin
>
>
> On Mon, Jul 5, 2021, at 06:00, Tom Bentley wrote:
> > During code review Chia-Ping noticed that the `throws
> InterruptedException`
> > clause on the declaration of KafkaFuture#getNow() is not needed. We
> propose
> > to remove it. Note that removing it is not a source compatible change
> since
> > existing code which caught InterruptedException would get a compile error
> > about the exception not being thrown in the try block.
> >
> > Please reply here if you want to discuss further, otherwise we'll assume
> > removing it is acceptable.
> >
> > Kind regards,
> >
> > Tom
> >
> >
> >
> > On Tue, Apr 6, 2021 at 4:08 PM Tom Bentley <tb...@redhat.com> wrote:
> >
> > > Hi,
> > >
> > > The vote passes with 4 binding +1s (Ismael, David Chia-Ping and Colin),
> > > and 1 non-binding +1 (Ryanne).
> > >
> > > Many thanks to those who commented and/or voted.
> > >
> > > Tom
> > >
> > > On Thu, Apr 1, 2021 at 8:21 PM Colin McCabe <cm...@apache.org>
> wrote:
> > >
> > >> +1 (binding). Thanks for the KIP.
> > >>
> > >> Colin
> > >>
> > >>
> > >> On Tue, Mar 30, 2021, at 20:36, Chia-Ping Tsai wrote:
> > >> > Thanks for this KIP. +1 (binding)
> > >> >
> > >> > On 2021/03/29 15:34:55, Tom Bentley <tb...@redhat.com> wrote:
> > >> > > Hi,
> > >> > >
> > >> > > I'd like to start a vote on KIP-707, which proposes to add
> > >> > > KafkaFuture.toCompletionStage(), deprecate KafkaFuture.Function
> and
> > >> make a
> > >> > > couple of other minor cosmetic changes.
> > >> > >
> > >> > >
> > >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-707%3A+The+future+of+KafkaFuture
> > >> > >
> > >> > > Many thanks,
> > >> > >
> > >> > > Tom
> > >> > >
> > >> >
> > >>
> > >>
> >
>
>
Re: [VOTE] KIP-707: The future of KafkaFuture
Posted by Colin McCabe <cm...@apache.org>.
Hi Tom,
We don't want to break source code compatibility, so I think we should avoid removing this exception.
best,
Colin
On Mon, Jul 5, 2021, at 06:00, Tom Bentley wrote:
> During code review Chia-Ping noticed that the `throws InterruptedException`
> clause on the declaration of KafkaFuture#getNow() is not needed. We propose
> to remove it. Note that removing it is not a source compatible change since
> existing code which caught InterruptedException would get a compile error
> about the exception not being thrown in the try block.
>
> Please reply here if you want to discuss further, otherwise we'll assume
> removing it is acceptable.
>
> Kind regards,
>
> Tom
>
>
>
> On Tue, Apr 6, 2021 at 4:08 PM Tom Bentley <tb...@redhat.com> wrote:
>
> > Hi,
> >
> > The vote passes with 4 binding +1s (Ismael, David Chia-Ping and Colin),
> > and 1 non-binding +1 (Ryanne).
> >
> > Many thanks to those who commented and/or voted.
> >
> > Tom
> >
> > On Thu, Apr 1, 2021 at 8:21 PM Colin McCabe <cm...@apache.org> wrote:
> >
> >> +1 (binding). Thanks for the KIP.
> >>
> >> Colin
> >>
> >>
> >> On Tue, Mar 30, 2021, at 20:36, Chia-Ping Tsai wrote:
> >> > Thanks for this KIP. +1 (binding)
> >> >
> >> > On 2021/03/29 15:34:55, Tom Bentley <tb...@redhat.com> wrote:
> >> > > Hi,
> >> > >
> >> > > I'd like to start a vote on KIP-707, which proposes to add
> >> > > KafkaFuture.toCompletionStage(), deprecate KafkaFuture.Function and
> >> make a
> >> > > couple of other minor cosmetic changes.
> >> > >
> >> > >
> >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-707%3A+The+future+of+KafkaFuture
> >> > >
> >> > > Many thanks,
> >> > >
> >> > > Tom
> >> > >
> >> >
> >>
> >>
>