[GitHub] [metron] nickwallen commented on issue #1501: METRON-2246 rpm-docker - minimise use of bind mounts due to performance

[GitBox <gi...@apache.org>]

nickwallen commented on issue #1501: METRON-2246 rpm-docker - minimise use of bind mounts due to performance
URL: https://github.com/apache/metron/pull/1501#issuecomment-536060437
 
 
   Here is what I am noticing with this change.
   
   If I both build the code and create the RPMs, I see times of roughly 11 - 12 minutes for RPM creation consistently.  Said a different way, the first time I create the RPMs, it takes 11 -12 minutes.
   ```
   mvn package -DskipTests -T 2C -P HDP-2.5.0.0,mpack
   cd metron-deployment/
   # this step takes 11 - 12 minutes
   time mvn clean package -Pbuild-rpms -T 2C
   ```
   
   Now, if I then attempt to create the RPMs again (without rebuilding the code), I do see improved times of roughly 8 - 9 minutes.
   ```
   mvn package -DskipTests -T 2C -P HDP-2.5.0.0,mpack
   cd metron-deployment/
   
   # right after I built the code, this takes 11 - 12 minutes
   time mvn clean package -Pbuild-rpms -T 2C
   
   # if I create the RPMs again, this takes 8 - 9 minutes
   time mvn clean package -Pbuild-rpms -T 2C
   ```
   
   I believe that once I do a mvn clean or rebuild the code, the next time I go about creating RPMs, it takes 11-12 minutes.  In master, no matter how I go about it, RPM creation takes 11 - 12 minutes.  
   
   @tigerquoll Why do you think this is?  Could the time savings here actually be from re-use of the phase 1 container?  Does the phase 1 container get removed after a clean?  
   
   I think your use of multi-stage Docker builds makes sense here, but I have not had a chance to dig-in to this enough to explain what I am seeing.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services