You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by weex-bot <gi...@git.apache.org> on 2017/08/24 07:54:44 UTC

[GitHub] incubator-weex issue #643: * [Android] Add the ability of flatgui

Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/643
  
    
    <!--
      2 failure:  This PR modify SD..., Code file android...
      9 warning:  No Changelog chan..., This PR should up..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C..., Potential BREAK C...
      1 messages
      
    -->
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Fails</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:no_entry_sign:</td>
          <td>This PR modify SDK code. Please add/modify corresponding testcases. If it is ok, please comment about it. Or put '@notdanger' in you commit message.</td>
        </tr>
      
    <tr>
          <td>:no_entry_sign:</td>
          <td>Code file android/commons/src/main/java/com/alibaba/weex/commons/adapter/PicassoBasedDrawableLoader.java does not have the copyright header.</td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>No Changelog changes!</td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>This PR should update related documents as well. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXText.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXDiv.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXCell.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/list/WXListComponent.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXVContainer.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXImage.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      
    <tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/ui/component/WXComponent.java without metion it in commit message. You'd better add '@notdanger' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Messages</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:book:</td>
          <td>According to the blame info, we recommended @sospartan , @luics to be the reviewers.</td>
        </tr>
      </tbody>
    </table>
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---