[GitHub] [hadoop] cxorm commented on a change in pull request #2836: HDFS-15936.Solve SocketTimeoutException#sendPacket() does not record SocketTimeout exception.

[GitBox <gi...@apache.org>]

cxorm commented on a change in pull request #2836:
URL: https://github.com/apache/hadoop/pull/2836#discussion_r603942103



##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java
##########
@@ -631,6 +631,7 @@ private int sendPacket(ByteBuffer pkt, int maxChunks, OutputStream out,
          * 
          * Reporting of this case is done in DataXceiver#run

Review comment:
       I am fine with the update though the exception would be threw and processed in `DataXceiver#run`

##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockSender.java
##########
@@ -631,6 +631,7 @@ private int sendPacket(ByteBuffer pkt, int maxChunks, OutputStream out,
          * 
          * Reporting of this case is done in DataXceiver#run

Review comment:
       I am fine with the update though the exception would be threw and processed in `DataXceiver#run`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org