[jira] [Commented] (FLINK-4143) Configurable delimiter for metric identifier

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367594#comment-15367594 ] 

ASF GitHub Bot commented on FLINK-4143:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2219

    [FLINK-4143][metrics] Configurable delimiter

    This PR makes the scope identifier delimiter configurable.
    
    * A new config Key "metrics.scope.delimiter" was added that is extracted in the MetricRegistry. 
    * A new method `getDelimiter()` was added to the MetricRegistry so that groups can access it.
    * The static concat() method now takes a delimiter argument.
    * The String returned by getScopeString() now always ends in the delimiter. (so that Reporters don't require access to the delimiter)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 4143_metrics_delim

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2219.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2219
    
----
commit 7da5aa9f7aa3292368d950b4ff1d3a68b3b1adb8
Author: zentol <ch...@apache.org>
Date:   2016-07-08T12:18:14Z

    [FLINK-4143][metrics] Configurable delimiter

----


> Configurable delimiter for metric identifier
> --------------------------------------------
>
>                 Key: FLINK-4143
>                 URL: https://issues.apache.org/jira/browse/FLINK-4143
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Minor
>
> The metric identifier is currently hard-coded to separate components with a dot.
> We should make this configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)