[GitHub] [accumulo] EdColeman commented on a change in pull request #2305: Replace hadoop metrics with micrometer

[GitBox <gi...@apache.org>]

EdColeman commented on a change in pull request #2305:
URL: https://github.com/apache/accumulo/pull/2305#discussion_r736600899



##########
File path: core/src/main/java/org/apache/accumulo/core/metrics/MetricsProducer.java
##########
@@ -504,6 +512,7 @@
 
   String METRICS_FATE_PREFIX = "accumulo.fate.";
   String METRICS_FATE_CURRENT_OPS = METRICS_FATE_PREFIX + "ops.current";
+  String METRICS_FATE_TOTAL_CURRENT_OPS = METRICS_FATE_PREFIX + "ops.total.current";
   String METRICS_FATE_TOTAL_OPS = METRICS_FATE_PREFIX + "ops.total";
   String METRICS_FATE_ERRORS = METRICS_FATE_PREFIX + "errors";

Review comment:
       I'm not sure of these names - ops.current, ops.total.current and ops.total - by name I can't tell what the meter is recording - for some metric systems, metrics can be sort of self documenting.  For those, it helps metrics users that may not be developers to reason about what is being reported as long as the names are meaningful, consistent... more of a soft goal rather than a requirement, but nice if we can move in that direction.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org