You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/08/07 02:16:33 UTC

[GitHub] [incubator-pinot] codecov-io commented on issue #4504: [Instance Assignment] Add implementations for instance assignment

codecov-io commented on issue #4504: [Instance Assignment] Add implementations for instance assignment
URL: https://github.com/apache/incubator-pinot/pull/4504#issuecomment-518911893
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4504?src=pr&el=h1) Report
   > :exclamation: No coverage uploaded for pull request base (`master@b73427d`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `95.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4504/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4504?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4504   +/-   ##
   =========================================
     Coverage          ?   65.72%           
     Complexity        ?       20           
   =========================================
     Files             ?     1072           
     Lines             ?    55688           
     Branches          ?     8111           
   =========================================
     Hits              ?    36603           
     Misses            ?    16427           
     Partials          ?     2658
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4504?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../common/config/instance/InstanceTagPoolConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4504/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlVGFnUG9vbENvbmZpZy5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | |
   | [...rg/apache/pinot/controller/api/pojos/Instance.java](https://codecov.io/gh/apache/incubator-pinot/pull/4504/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcG9qb3MvSW5zdGFuY2UuamF2YQ==) | `42% <ø> (ø)` | `0 <0> (?)` | |
   | [...RealtimeReplicaGroupSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4504/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9SZWFsdGltZVJlcGxpY2FHcm91cFNlZ21lbnRBc3NpZ25tZW50U3RyYXRlZ3kuamF2YQ==) | `98.18% <ø> (ø)` | `0 <0> (?)` | |
   | [...he/pinot/common/config/SegmentPartitionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4504/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1NlZ21lbnRQYXJ0aXRpb25Db25maWcuamF2YQ==) | `50% <0%> (ø)` | `0 <0> (?)` | |
   | [...config/instance/InstanceAssignmentConfigUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4504/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlQXNzaWdubWVudENvbmZpZ1V0aWxzLmphdmE=) | `75% <100%> (ø)` | `0 <0> (?)` | |
   | [...onfig/instance/InstanceReplicaPartitionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4504/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlUmVwbGljYVBhcnRpdGlvbkNvbmZpZy5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...ance/HashBasedRotateInstanceConstraintApplier.java](https://codecov.io/gh/apache/incubator-pinot/pull/4504/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvaW5zdGFuY2UvSGFzaEJhc2VkUm90YXRlSW5zdGFuY2VDb25zdHJhaW50QXBwbGllci5qYXZh) | `92.3% <92.3%> (ø)` | `0 <0> (?)` | |
   | [...e/assignment/instance/InstanceTagPoolSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/4504/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvaW5zdGFuY2UvSW5zdGFuY2VUYWdQb29sU2VsZWN0b3IuamF2YQ==) | `94.64% <94.64%> (ø)` | `0 <0> (?)` | |
   | [.../assignment/instance/InstanceAssignmentDriver.java](https://codecov.io/gh/apache/incubator-pinot/pull/4504/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvaW5zdGFuY2UvSW5zdGFuY2VBc3NpZ25tZW50RHJpdmVyLmphdmE=) | `95.83% <95.83%> (ø)` | `0 <0> (?)` | |
   | [...ent/instance/InstanceReplicaPartitionSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/4504/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvaW5zdGFuY2UvSW5zdGFuY2VSZXBsaWNhUGFydGl0aW9uU2VsZWN0b3IuamF2YQ==) | `97.82% <97.82%> (ø)` | `0 <0> (?)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4504?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4504?src=pr&el=footer). Last update [b73427d...b6d1437](https://codecov.io/gh/apache/incubator-pinot/pull/4504?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org