You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by du...@apache.org on 2021/05/23 12:34:16 UTC
[rocketmq] branch develop updated: #2935 check kv config should not
be null
This is an automated email from the ASF dual-hosted git repository.
duhengforever pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git
The following commit(s) were added to refs/heads/develop by this push:
new 5829fbd #2935 check kv config should not be null
new 0430860 Merge pull request #2936 from yuz10/develop3
5829fbd is described below
commit 5829fbd44965ed6d2559302f7ec5a1dd5b2a9de1
Author: yuz10 <84...@qq.com>
AuthorDate: Fri May 21 23:12:43 2021 +0800
#2935 check kv config should not be null
---
.../apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
index 44a2b6f..f8bc55e 100644
--- a/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
+++ b/namesrv/src/main/java/org/apache/rocketmq/namesrv/processor/DefaultRequestProcessor.java
@@ -140,6 +140,11 @@ public class DefaultRequestProcessor extends AsyncNettyRequestProcessor implemen
final PutKVConfigRequestHeader requestHeader =
(PutKVConfigRequestHeader) request.decodeCommandCustomHeader(PutKVConfigRequestHeader.class);
+ if (requestHeader.getNamespace() == null || requestHeader.getKey() == null) {
+ response.setCode(ResponseCode.SYSTEM_ERROR);
+ response.setRemark("namespace or key is null");
+ return response;
+ }
this.namesrvController.getKvConfigManager().putKVConfig(
requestHeader.getNamespace(),
requestHeader.getKey(),