You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2020/05/31 05:26:11 UTC
[hbase] branch branch-2.3 updated: HBASE-24475 Clean up the master
thread name getting in SplitLogManager and AssignmentManager (#1810)
This is an automated email from the ASF dual-hosted git repository.
stack pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.3 by this push:
new 6d5ac6c HBASE-24475 Clean up the master thread name getting in SplitLogManager and AssignmentManager (#1810)
6d5ac6c is described below
commit 6d5ac6c1489760b45b672afa8896ca5e30004e4e
Author: bsglz <18...@qq.com>
AuthorDate: Sun May 31 13:23:04 2020 +0800
HBASE-24475 Clean up the master thread name getting in SplitLogManager and AssignmentManager (#1810)
---
.../main/java/org/apache/hadoop/hbase/master/SplitLogManager.java | 6 +-----
.../apache/hadoop/hbase/master/assignment/AssignmentManager.java | 6 +-----
2 files changed, 2 insertions(+), 10 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
index b2e99b2..2bdfa03 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java
@@ -121,12 +121,8 @@ public class SplitLogManager {
throws IOException {
this.server = master;
this.conf = conf;
- // Get Server Thread name. Sometimes the Server is mocked so may not extends Thread.
- // For example, in tests.
- String name = master instanceof Thread? ((Thread)master).getName():
- master.getServerName().toShortString();
this.choreService =
- new ChoreService(name + ".splitLogManager.");
+ new ChoreService(master.getServerName().toShortString() + ".splitLogManager.");
if (server.getCoordinatedStateManager() != null) {
SplitLogManagerCoordination coordination = getSplitLogManagerCoordination();
Set<String> failedDeletions = Collections.synchronizedSet(new HashSet<String>());
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
index 9e2819d..b3d4de4 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
@@ -1896,11 +1896,7 @@ public class AssignmentManager {
}
private void startAssignmentThread() {
- // Get Server Thread name. Sometimes the Server is mocked so may not implement Thread.
- // For example, in tests.
- String name = master instanceof Thread? ((Thread)master).getName():
- master.getServerName().toShortString();
- assignThread = new Thread(name) {
+ assignThread = new Thread(master.getServerName().toShortString()) {
@Override
public void run() {
while (isRunning()) {