You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "mbien (via GitHub)" <gi...@apache.org> on 2024/11/29 20:57:43 UTC
[PR] Remove java.security.manager=allow flag from launcher. [netbeans]
mbien opened a new pull request, #8009:
URL: https://github.com/apache/netbeans/pull/8009
this commit implements SM removal step 1 of 3
1) remove SM flag from launcher and release new launcher bits
2) move flag to config and switch to new launcher bits
3) implement SM removal for JDK 24 compatibility
extracted from #7928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#discussion_r1869026606
##########
platform/o.n.bootstrap/launcher/windows/version.h:
##########
@@ -19,9 +19,9 @@
#define COMPANY ""
#define COMPONENT "Apache NetBeans Platform Launcher"
-#define VER "101.1.0.0"
-#define FVER 101,1,0,0
-#define BUILD_ID "101100"
+#define VER "101.1.1.0"
+#define FVER 101,1,1,0
+#define BUILD_ID "101110"
Review Comment:
i bumped the version in both, IDE and platform launcher `version.h` - just to be sure. (Its all in the same zip artifact anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2545726720
The change itself is fine, the _need_ to change, which shows that the build environment we're using for the distributed natives has changed, is what concerns me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#discussion_r1869054863
##########
platform/o.n.bootstrap/launcher/windows/version.h:
##########
@@ -19,9 +19,9 @@
#define COMPANY ""
#define COMPONENT "Apache NetBeans Platform Launcher"
-#define VER "101.1.0.0"
-#define FVER 101,1,0,0
-#define BUILD_ID "101100"
+#define VER "101.1.1.0"
+#define FVER 101,1,1,0
+#define BUILD_ID "101110"
Review Comment:
split into extra commit and updated the manifests (changed changed the version too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from launcher. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2515358066
@mbien well, it should be testable from https://github.com/apache/netbeans/actions/runs/12091765448
Will need a version update before attempting to move to vote, in manner outlined at https://github.com/apache/netbeans/pull/6869#issuecomment-1875153302
There are a couple of other changes that would be nice to get in to the launcher if we're going for an update, but something to discuss elsewhere ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2545496116
> The need to adapt to the compiler on the newer CI image concerns me.
the NULL comparison change is something which should be done in any case. Comparing a pointer using `>` with 0 seems to be error prone - a warning might have switched to an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2543968171
i tested this with the following setup:
- win 10
- jdk 24 build 28
- NB dev build taken from https://github.com/apache/netbeans/pull/7928
- launcher binaries from this PR ([artifacts](https://github.com/apache/netbeans/actions/runs/12340686815?pr=8009))
and it seems to work fine:
```
-------------------------------------------------------------------------------
>Log Session: Sunday, December 15, 2024, 5:22:23 PM Greenwich Mean Time
>System Info:
Product Version = Apache NetBeans IDE DEV (Build dev-3687560331e398c3854f24675c36c44c48dcb804)
Operating System = Windows 10 version 10.0 running on amd64
Java; VM; Vendor = 24-ea; OpenJDK 64-Bit Server VM 24-ea+28-3562; Oracle Corporation
Runtime = OpenJDK Runtime Environment 24-ea+28-3562
Java Home = C:\Users\virtual10\Downloads\openjdk-24-ea+28_windows-x64_bin\jdk-24
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2545968960
rebased on top of https://github.com/apache/netbeans/pull/8062 which locks binaries build to ubuntu 22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2545087820
The need to adapt to the compiler on the newer CI image concerns me. I think we should pin all the native build workflows to the lowest supported image for broadest compatibility, before moving to further releases of any. Ideally we'd disconnect the runner OS from the compiler and library versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from launcher. [netbeans]
Posted by "lkishalmi (via GitHub)" <gi...@apache.org>.
lkishalmi commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2512880980
Not familiar with the windows native launcher though it looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#discussion_r1905102085
##########
platform/o.n.bootstrap/launcher/windows/jvmlauncher.cpp:
##########
@@ -249,7 +249,7 @@ bool JvmLauncher::startInProcJvm(const char *mainClassName, const std::list<std:
for (list<string>::const_iterator it = options.begin(); it != options.end(); ++it, ++i) {
const string &option = *it;
logMsg("\t%s", option.c_str());
- if (option.find("-splash:") == 0 && hSplash > 0) {
+ if (option.find("-splash:") == 0 && hSplash != (void *) NULL) {
Review Comment:
> or is the used C++ version too old for that?
@ExE-Boss hi! The build image is locked to [ubuntu 22](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#installed-apt-packages) since the last LTS is soon eol. So the tooling env isn't super old.
I can change this if this is the cleaner way to do that comparison. Thanks for the review btw!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2575983730
@matthiasblaesing no worries, I know that you tested it from the dev list
btw opened PR for step 2: https://github.com/apache/netbeans/pull/8122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2574625939
as mentioned on the dev list, planning to merge this in about 10h unless told otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2574966157
rebased again to check if the right notice file is picked up by the build + added `nullptr` suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2512893257
> Not familiar with the windows native launcher though it looks good to me.
me neither. I have to check the past PRs and take a look what needs to be done before a release. Probably a version bump somewhere too. Then actually test it on windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#discussion_r1905102085
##########
platform/o.n.bootstrap/launcher/windows/jvmlauncher.cpp:
##########
@@ -249,7 +249,7 @@ bool JvmLauncher::startInProcJvm(const char *mainClassName, const std::list<std:
for (list<string>::const_iterator it = options.begin(); it != options.end(); ++it, ++i) {
const string &option = *it;
logMsg("\t%s", option.c_str());
- if (option.find("-splash:") == 0 && hSplash > 0) {
+ if (option.find("-splash:") == 0 && hSplash != (void *) NULL) {
Review Comment:
> or is the used C++ version too old for that?
@ExE-Boss hi! The build image is locked to [ubuntu 22](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#language-and-runtime) since the last LTS is soon eol. So the tooling env isn't super old.
I can change this if this is the cleaner way to do that comparison. Thanks for the review btw!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2516619909
@mbien check https://github.com/apache/netbeans/pull/6869/commits/b8e969aa0f5345a6d94254f09a601b9418c0ecfb which has all the places this needs setting.
Please use `101.2.0.0` - unless there's a particular reason not to?
Please do the version change in a separate commit this time - I failed to do that, but should have in hindsight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#discussion_r1869036309
##########
platform/o.n.bootstrap/launcher/windows/version.h:
##########
@@ -19,9 +19,9 @@
#define COMPANY ""
#define COMPONENT "Apache NetBeans Platform Launcher"
-#define VER "101.1.0.0"
-#define FVER 101,1,0,0
-#define BUILD_ID "101100"
+#define VER "101.1.1.0"
+#define FVER 101,1,1,0
+#define BUILD_ID "101110"
Review Comment:
Also need the `.manifest` files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#issuecomment-2543870834
the launcher build started failing on CI recently. Probably due to the ubuntu image update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#discussion_r1869054863
##########
platform/o.n.bootstrap/launcher/windows/version.h:
##########
@@ -19,9 +19,9 @@
#define COMPANY ""
#define COMPONENT "Apache NetBeans Platform Launcher"
-#define VER "101.1.0.0"
-#define FVER 101,1,0,0
-#define BUILD_ID "101100"
+#define VER "101.1.1.0"
+#define FVER 101,1,1,0
+#define BUILD_ID "101110"
Review Comment:
split into extra commit and updated the manifests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #8009:
URL: https://github.com/apache/netbeans/pull/8009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove java.security.manager=allow flag from windows launcher. [netbeans]
Posted by "ExE-Boss (via GitHub)" <gi...@apache.org>.
ExE-Boss commented on code in PR #8009:
URL: https://github.com/apache/netbeans/pull/8009#discussion_r1905087280
##########
platform/o.n.bootstrap/launcher/windows/jvmlauncher.cpp:
##########
@@ -249,7 +249,7 @@ bool JvmLauncher::startInProcJvm(const char *mainClassName, const std::list<std:
for (list<string>::const_iterator it = options.begin(); it != options.end(); ++it, ++i) {
const string &option = *it;
logMsg("\t%s", option.c_str());
- if (option.find("-splash:") == 0 && hSplash > 0) {
+ if (option.find("-splash:") == 0 && hSplash != (void *) NULL) {
Review Comment:
Can this use `nullptr` instead of `NULL`, or is the used **C++** version too old for that?
```suggestion
if (option.find("-splash:") == 0 && hSplash != nullptr) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists