You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/15 18:32:45 UTC
[GitHub] [incubator-superset] kkucharc opened a new pull request #12061: feat(logs): security permissions simplification
kkucharc opened a new pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061
### SUMMARY
Updated annotations and annotation layers security permissions.
LogModelView can_show -> Log can_read
LogModelView can_add -> Log can_write
LogModelView can_list -> Log can_read
Current state:
View | Permission
-----|-------
LogModelView | can_show
LogModelView | can_list
LogModelView | can_add
New state:
View | Permission
-----|-------
Log | can_write
Log | can_read
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=h1) Report
> Merging [#12061](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=desc) (696a29a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7dac150dc6f9279c93a832e509aaa89bd35412bb?el=desc) (7dac150) will **decrease** coverage by `11.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12061 +/- ##
===========================================
- Coverage 63.81% 52.64% -11.18%
===========================================
Files 956 438 -518
Lines 46845 15714 -31131
Branches 4590 4060 -530
===========================================
- Hits 29895 8272 -21623
+ Misses 16766 7442 -9324
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.64% <ø> (?)` | |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| ... and [863 more](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=footer). Last update [7dac150...696a29a](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=h1) Report
> Merging [#12061](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=desc) (b810567) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.36%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12061 +/- ##
==========================================
- Coverage 67.55% 64.19% -3.37%
==========================================
Files 959 477 -482
Lines 47154 29420 -17734
Branches 4609 0 -4609
==========================================
- Hits 31857 18887 -12970
+ Misses 15185 10533 -4652
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.19% <16.66%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ns/versions/4b84f97828aa\_security\_converge\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80Yjg0Zjk3ODI4YWFfc2VjdXJpdHlfY29udmVyZ2VfbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `91.01% <ø> (ø)` | |
| [superset/views/log/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| [...rset-frontend/src/components/NavDropdown/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTmF2RHJvcGRvd24vaW5kZXgudHN4) | | |
| [...ntend/src/components/Checkbox/Checkbox.stories.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3guc3Rvcmllcy5qc3g=) | | |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | | |
| ... and [481 more](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=footer). Last update [2302adb...b810567](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=h1) Report
> Merging [#12061](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=desc) (b810567) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `7.22%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12061 +/- ##
==========================================
- Coverage 67.55% 60.33% -7.23%
==========================================
Files 959 915 -44
Lines 47154 45172 -1982
Branches 4609 4079 -530
==========================================
- Hits 31857 27256 -4601
- Misses 15185 17916 +2731
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.12% <ø> (+<0.01%)` | :arrow_up: |
| javascript | `?` | |
| python | `64.19% <16.66%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ns/versions/4b84f97828aa\_security\_converge\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80Yjg0Zjk3ODI4YWFfc2VjdXJpdHlfY29udmVyZ2VfbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `91.01% <ø> (ø)` | |
| [superset/views/log/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [342 more](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=footer). Last update [2302adb...b810567](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=h1) Report
> Merging [#12061](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=desc) (6c2129a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `4.88%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12061 +/- ##
==========================================
- Coverage 67.55% 62.67% -4.89%
==========================================
Files 959 483 -476
Lines 47154 17754 -29400
Branches 4609 4609
==========================================
- Hits 31857 11127 -20730
+ Misses 15185 6443 -8742
- Partials 112 184 +72
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.67% <ø> (ø)` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/dashboard/containers/DashboardBuilder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEJ1aWxkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [643 more](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=footer). Last update [2302adb...52e5ea2](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=h1) Report
> Merging [#12061](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=desc) (b810567) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.96%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12061 +/- ##
==========================================
- Coverage 67.55% 63.59% -3.97%
==========================================
Files 959 477 -482
Lines 47154 29405 -17749
Branches 4609 0 -4609
==========================================
- Hits 31857 18700 -13157
+ Misses 15185 10705 -4480
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.59% <16.66%> (-0.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ns/versions/4b84f97828aa\_security\_converge\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80Yjg0Zjk3ODI4YWFfc2VjdXJpdHlfY29udmVyZ2VfbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `91.01% <ø> (ø)` | |
| [superset/views/log/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.95% <0.00%> (-12.45%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `96.42% <0.00%> (-3.58%)` | :arrow_down: |
| ... and [499 more](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=footer). Last update [2302adb...b810567](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=h1) Report
> Merging [#12061](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=desc) (b810567) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.51%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12061 +/- ##
==========================================
- Coverage 67.55% 64.04% -3.52%
==========================================
Files 959 477 -482
Lines 47154 29420 -17734
Branches 4609 0 -4609
==========================================
- Hits 31857 18841 -13016
+ Misses 15185 10579 -4606
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.04% <16.66%> (-0.27%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ns/versions/4b84f97828aa\_security\_converge\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80Yjg0Zjk3ODI4YWFfc2VjdXJpdHlfY29udmVyZ2VfbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `91.01% <ø> (ø)` | |
| [superset/views/log/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `73.81% <0.00%> (-8.59%)` | :arrow_down: |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | `97.10% <0.00%> (-2.90%)` | :arrow_down: |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | `96.51% <0.00%> (-2.33%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.80% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| ... and [485 more](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=footer). Last update [2302adb...b810567](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=h1) Report
> Merging [#12061](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=desc) (b810567) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `7.38%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12061 +/- ##
==========================================
- Coverage 67.55% 60.17% -7.39%
==========================================
Files 959 915 -44
Lines 47154 45172 -1982
Branches 4609 4079 -530
==========================================
- Hits 31857 27181 -4676
- Misses 15185 17991 +2806
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.65% <ø> (-0.48%)` | :arrow_down: |
| javascript | `?` | |
| python | `64.19% <16.66%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ns/versions/4b84f97828aa\_security\_converge\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80Yjg0Zjk3ODI4YWFfc2VjdXJpdHlfY29udmVyZ2VfbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `91.01% <ø> (ø)` | |
| [superset/views/log/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100.00% <100.00%> (ø)` | |
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| ... and [343 more](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=footer). Last update [2302adb...b810567](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=h1) Report
> Merging [#12061](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=desc) (b810567) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.36%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12061 +/- ##
==========================================
- Coverage 67.55% 64.19% -3.37%
==========================================
Files 959 477 -482
Lines 47154 29420 -17734
Branches 4609 0 -4609
==========================================
- Hits 31857 18887 -12970
+ Misses 15185 10533 -4652
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.19% <16.66%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ns/versions/4b84f97828aa\_security\_converge\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80Yjg0Zjk3ODI4YWFfc2VjdXJpdHlfY29udmVyZ2VfbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `91.01% <ø> (ø)` | |
| [superset/views/log/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| [...d/src/dashboard/components/gridComponents/index.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL2luZGV4Lmpz) | | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | | |
| [...t-frontend/src/dashboard/reducers/sliceEntities.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9zbGljZUVudGl0aWVzLmpz) | | |
| ... and [481 more](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=footer). Last update [2302adb...b810567](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=h1) Report
> Merging [#12061](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=desc) (696a29a) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7dac150dc6f9279c93a832e509aaa89bd35412bb?el=desc) (7dac150) will **decrease** coverage by `10.69%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12061 +/- ##
===========================================
- Coverage 63.81% 53.11% -10.70%
===========================================
Files 956 438 -518
Lines 46845 15714 -31131
Branches 4590 4060 -530
===========================================
- Hits 29895 8347 -21548
+ Misses 16766 7367 -9399
+ Partials 184 0 -184
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.11% <ø> (?)` | |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/alert/ExecutionLog.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvRXhlY3V0aW9uTG9nLnRzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
| [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/getDashboardFilterKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERhc2hib2FyZEZpbHRlcktleS50cw==) | `14.28% <0.00%> (-85.72%)` | :arrow_down: |
| [...end/src/SqlLab/components/ExploreResultsButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0V4cGxvcmVSZXN1bHRzQnV0dG9uLmpzeA==) | `8.00% <0.00%> (-84.00%)` | :arrow_down: |
| [...nd/src/views/CRUD/data/query/QueryPreviewModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9xdWVyeS9RdWVyeVByZXZpZXdNb2RhbC50c3g=) | `14.70% <0.00%> (-82.97%)` | :arrow_down: |
| ... and [864 more](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=footer). Last update [7dac150...696a29a](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12061: feat(logs): security permissions simplification
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12061:
URL: https://github.com/apache/incubator-superset/pull/12061#issuecomment-745501202
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=h1) Report
> Merging [#12061](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=desc) (b810567) into [master](https://codecov.io/gh/apache/incubator-superset/commit/2302adb61ac5bf969f5687b894d39cff67f79c79?el=desc) (2302adb) will **decrease** coverage by `3.36%`.
> The diff coverage is `16.66%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12061 +/- ##
==========================================
- Coverage 67.55% 64.19% -3.37%
==========================================
Files 959 477 -482
Lines 47154 29420 -17734
Branches 4609 0 -4609
==========================================
- Hits 31857 18887 -12970
+ Misses 15185 10533 -4652
+ Partials 112 0 -112
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `64.19% <16.66%> (-0.12%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ns/versions/4b84f97828aa\_security\_converge\_logs.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80Yjg0Zjk3ODI4YWFfc2VjdXJpdHlfY29udmVyZ2VfbG9ncy5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `91.01% <ø> (ø)` | |
| [superset/views/log/api.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL2FwaS5weQ==) | `100.00% <100.00%> (ø)` | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.07% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.00% <0.00%> (-0.46%)` | :arrow_down: |
| [superset-frontend/src/explore/store.js](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvc3RvcmUuanM=) | | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | | |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | | |
| ... and [481 more](https://codecov.io/gh/apache/incubator-superset/pull/12061/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=footer). Last update [2302adb...b810567](https://codecov.io/gh/apache/incubator-superset/pull/12061?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org