You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/12 11:29:20 UTC
[GitHub] [superset] geido opened a new pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
geido opened a new pull request #17422:
URL: https://github.com/apache/superset/pull/17422
### SUMMARY
This PR:
- Adds the ability to notify the user about custom label colors used in a Dashboard
- Adds the ability to inform the user when a chart in Explore is having a dashboard context, thus the color scheme will be inherited from the dashboard.
- Adds some test cases for the ColorSchemeControl which had none before
- Fixes #17318
### AFTER DASHBOARD
https://user-images.githubusercontent.com/60598000/141459740-af81102e-c468-4fd7-855d-535c5c280804.mp4
### AFTER EXPLORE
https://user-images.githubusercontent.com/60598000/141459760-df5ed5b2-5888-4554-bb79-b116f7b1e5e3.mp4
### TESTING INSTRUCTIONS
1. Open a Dashboard
2. Set a color scheme
3. Add custom label colors
4. Make sure the color scheme alerts you of custom label colors in use
4. Visit a chart
5. Make sure the color scheme cannot be changed in Explore
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #17318
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #17422:
URL: https://github.com/apache/superset/pull/17422#discussion_r748250047
##########
File path: superset-frontend/src/explore/components/controls/ColorSchemeControl/index.jsx
##########
@@ -101,43 +115,93 @@ export default class ColorSchemeControl extends React.PureComponent {
</li>
))}
</ul>
- </Tooltip>
+ </span>
);
}
+ renderLabel() {
+ const { dashboardId, hasCustomLabelColors, label } = this.props;
+
+ if (hasCustomLabelColors || dashboardId) {
+ const alertTitle = hasCustomLabelColors
+ ? t(
+ `This color scheme is being overriden by custom label colors.
+ Check the JSON metadata in the Advanced settings`,
+ )
+ : this.dashboardColorSchemeAlert;
+ return (
+ <>
+ {label}{' '}
+ <Tooltip title={alertTitle}>
+ <StyledAlert iconSize="s" />
+ </Tooltip>
+ </>
+ );
+ }
+ return label;
+ }
+
render() {
- const { schemes, choices } = this.props;
- // save parsed schemes for later
- this.schemes = isFunction(schemes) ? schemes() : schemes;
+ const { choices, dashboardId, schemes } = this.props;
+ let options = dashboardId
+ ? [
+ {
+ value: 'dashboard',
+ label: 'dashboard',
+ customLabel: (
+ <Tooltip title={this.dashboardColorSchemeAlert}>
+ {t('Dashboard scheme')}
+ </Tooltip>
+ ),
+ },
+ ]
+ : [];
+ let currentScheme = dashboardId ? 'dashboard' : undefined;
- const allColorOptions = (isFunction(choices) ? choices() : choices).filter(
- o => o[0] !== 'SUPERSET_DEFAULT',
- );
- const options = allColorOptions.map(([value]) => ({
- value,
- label: this.schemes?.[value]?.label || value,
- customLabel: this.renderOption(value),
- }));
-
- let currentScheme =
- this.props.value ||
- (this.props.default !== undefined ? this.props.default : undefined);
-
- if (currentScheme === 'SUPERSET_DEFAULT') {
- currentScheme = this.schemes?.SUPERSET_DEFAULT?.id;
+ // if related to a dashboard the scheme is dictated by the dashboard
+ if (!dashboardId) {
+ this.schemes = isFunction(schemes) ? schemes() : schemes;
+ const controlChoices = isFunction(choices) ? choices() : choices;
+ const allColorOptions = [];
+ const filteredColorOptions = controlChoices.filter(o => {
+ const option = o[0];
+ const isValidColorOption =
+ option !== 'SUPERSET_DEFAULT' && !allColorOptions.includes(option);
+ allColorOptions.push(option);
+ return isValidColorOption;
+ });
+
+ options = filteredColorOptions.map(([value]) => ({
+ customLabel: this.renderOption(value),
+ label: this.schemes?.[value]?.label || value,
+ value,
+ }));
+
+ currentScheme =
+ this.props.value ||
+ (this.props.default !== undefined ? this.props.default : undefined);
Review comment:
`default` could also be `null` and `null` it's an acceptable value for the Select. That's the reason of the strict check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17422:
URL: https://github.com/apache/superset/pull/17422#issuecomment-967067578
# [Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17422](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd7aa08) into [master](https://codecov.io/gh/apache/superset/commit/ffa55f7b7fe147f945ac16935206875c5e260969?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffa55f7) will **increase** coverage by `0.01%`.
> The diff coverage is `94.00%`.
> :exclamation: Current head bd7aa08 differs from pull request most recent head 397938d. Consider uploading reports for the commit 397938d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17422 +/- ##
==========================================
+ Coverage 77.01% 77.03% +0.01%
==========================================
Files 1040 1040
Lines 56077 56112 +35
Branches 7738 7750 +12
==========================================
+ Hits 43190 43224 +34
- Misses 12629 12630 +1
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.25% <94.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/components/controls/ColorSchemeControl/index.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wvaW5kZXguanN4) | `73.21% <90.90%> (ø)` | |
| [...dashboard/components/ColorSchemeControlWrapper.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yU2NoZW1lQ29udHJvbFdyYXBwZXIuanN4) | `81.25% <100.00%> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.23% <100.00%> (+2.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ffa55f7...397938d](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17422:
URL: https://github.com/apache/superset/pull/17422#issuecomment-967149881
@geido Ephemeral environment spinning up at http://34.209.144.65:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #17422:
URL: https://github.com/apache/superset/pull/17422#issuecomment-967148528
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 commented on pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
amitmiran137 commented on pull request #17422:
URL: https://github.com/apache/superset/pull/17422#issuecomment-967033770
This is great 👌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17422:
URL: https://github.com/apache/superset/pull/17422#issuecomment-967067578
# [Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17422](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71bb1b1) into [master](https://codecov.io/gh/apache/superset/commit/ffa55f7b7fe147f945ac16935206875c5e260969?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffa55f7) will **increase** coverage by `0.01%`.
> The diff coverage is `94.00%`.
> :exclamation: Current head 71bb1b1 differs from pull request most recent head 397938d. Consider uploading reports for the commit 397938d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17422 +/- ##
==========================================
+ Coverage 77.01% 77.03% +0.01%
==========================================
Files 1040 1040
Lines 56077 56112 +35
Branches 7738 7750 +12
==========================================
+ Hits 43190 43224 +34
- Misses 12629 12630 +1
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.25% <94.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/components/controls/ColorSchemeControl/index.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wvaW5kZXguanN4) | `73.21% <90.90%> (ø)` | |
| [...dashboard/components/ColorSchemeControlWrapper.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yU2NoZW1lQ29udHJvbFdyYXBwZXIuanN4) | `81.25% <100.00%> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.23% <100.00%> (+2.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ffa55f7...397938d](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17422:
URL: https://github.com/apache/superset/pull/17422#issuecomment-970404270
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido merged pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
geido merged pull request #17422:
URL: https://github.com/apache/superset/pull/17422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #17422:
URL: https://github.com/apache/superset/pull/17422#discussion_r748250047
##########
File path: superset-frontend/src/explore/components/controls/ColorSchemeControl/index.jsx
##########
@@ -101,43 +115,93 @@ export default class ColorSchemeControl extends React.PureComponent {
</li>
))}
</ul>
- </Tooltip>
+ </span>
);
}
+ renderLabel() {
+ const { dashboardId, hasCustomLabelColors, label } = this.props;
+
+ if (hasCustomLabelColors || dashboardId) {
+ const alertTitle = hasCustomLabelColors
+ ? t(
+ `This color scheme is being overriden by custom label colors.
+ Check the JSON metadata in the Advanced settings`,
+ )
+ : this.dashboardColorSchemeAlert;
+ return (
+ <>
+ {label}{' '}
+ <Tooltip title={alertTitle}>
+ <StyledAlert iconSize="s" />
+ </Tooltip>
+ </>
+ );
+ }
+ return label;
+ }
+
render() {
- const { schemes, choices } = this.props;
- // save parsed schemes for later
- this.schemes = isFunction(schemes) ? schemes() : schemes;
+ const { choices, dashboardId, schemes } = this.props;
+ let options = dashboardId
+ ? [
+ {
+ value: 'dashboard',
+ label: 'dashboard',
+ customLabel: (
+ <Tooltip title={this.dashboardColorSchemeAlert}>
+ {t('Dashboard scheme')}
+ </Tooltip>
+ ),
+ },
+ ]
+ : [];
+ let currentScheme = dashboardId ? 'dashboard' : undefined;
- const allColorOptions = (isFunction(choices) ? choices() : choices).filter(
- o => o[0] !== 'SUPERSET_DEFAULT',
- );
- const options = allColorOptions.map(([value]) => ({
- value,
- label: this.schemes?.[value]?.label || value,
- customLabel: this.renderOption(value),
- }));
-
- let currentScheme =
- this.props.value ||
- (this.props.default !== undefined ? this.props.default : undefined);
-
- if (currentScheme === 'SUPERSET_DEFAULT') {
- currentScheme = this.schemes?.SUPERSET_DEFAULT?.id;
+ // if related to a dashboard the scheme is dictated by the dashboard
+ if (!dashboardId) {
+ this.schemes = isFunction(schemes) ? schemes() : schemes;
+ const controlChoices = isFunction(choices) ? choices() : choices;
+ const allColorOptions = [];
+ const filteredColorOptions = controlChoices.filter(o => {
+ const option = o[0];
+ const isValidColorOption =
+ option !== 'SUPERSET_DEFAULT' && !allColorOptions.includes(option);
+ allColorOptions.push(option);
+ return isValidColorOption;
+ });
+
+ options = filteredColorOptions.map(([value]) => ({
+ customLabel: this.renderOption(value),
+ label: this.schemes?.[value]?.label || value,
+ value,
+ }));
+
+ currentScheme =
+ this.props.value ||
+ (this.props.default !== undefined ? this.props.default : undefined);
Review comment:
`default` could also be `null` and `null` it's an acceptable value for the Select. That's the reason of the strict check here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17422:
URL: https://github.com/apache/superset/pull/17422#issuecomment-967067578
# [Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17422](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd7aa08) into [master](https://codecov.io/gh/apache/superset/commit/9ce6b7de839b28308d0f84e5d9abeb87d33a33a7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ce6b7d) will **increase** coverage by `0.20%`.
> The diff coverage is `94.00%`.
> :exclamation: Current head bd7aa08 differs from pull request most recent head 4827e78. Consider uploading reports for the commit 4827e78 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17422 +/- ##
==========================================
+ Coverage 76.82% 77.03% +0.20%
==========================================
Files 1041 1040 -1
Lines 56063 56112 +49
Branches 7738 7750 +12
==========================================
+ Hits 43070 43224 +154
+ Misses 12735 12630 -105
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.25% <94.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/components/controls/ColorSchemeControl/index.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wvaW5kZXguanN4) | `73.21% <90.90%> (ø)` | |
| [...dashboard/components/ColorSchemeControlWrapper.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yU2NoZW1lQ29udHJvbFdyYXBwZXIuanN4) | `81.25% <100.00%> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.23% <100.00%> (+2.02%)` | :arrow_up: |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `81.05% <0.00%> (-4.18%)` | :arrow_down: |
| [superset/charts/commands/data.py](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RhdGEucHk=) | `96.36% <0.00%> (-1.60%)` | :arrow_down: |
| [superset/charts/data/api.py](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2RhdGEvYXBpLnB5) | `88.23% <0.00%> (-0.26%)` | :arrow_down: |
| [superset/charts/data/query\_context\_cache\_loader.py](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2RhdGEvcXVlcnlfY29udGV4dF9jYWNoZV9sb2FkZXIucHk=) | | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `90.10% <0.00%> (+0.12%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.58% <0.00%> (+0.38%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `90.00% <0.00%> (+0.73%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9ce6b7d...4827e78](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on a change in pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
kgabryje commented on a change in pull request #17422:
URL: https://github.com/apache/superset/pull/17422#discussion_r748223348
##########
File path: superset-frontend/src/explore/components/controls/ColorSchemeControl/index.jsx
##########
@@ -101,43 +115,93 @@ export default class ColorSchemeControl extends React.PureComponent {
</li>
))}
</ul>
- </Tooltip>
+ </span>
);
}
+ renderLabel() {
+ const { dashboardId, hasCustomLabelColors, label } = this.props;
+
+ if (hasCustomLabelColors || dashboardId) {
+ const alertTitle = hasCustomLabelColors
+ ? t(
+ `This color scheme is being overriden by custom label colors.
+ Check the JSON metadata in the Advanced settings`,
+ )
+ : this.dashboardColorSchemeAlert;
+ return (
+ <>
+ {label}{' '}
+ <Tooltip title={alertTitle}>
+ <StyledAlert iconSize="s" />
+ </Tooltip>
+ </>
+ );
+ }
+ return label;
+ }
+
render() {
- const { schemes, choices } = this.props;
- // save parsed schemes for later
- this.schemes = isFunction(schemes) ? schemes() : schemes;
+ const { choices, dashboardId, schemes } = this.props;
+ let options = dashboardId
+ ? [
+ {
+ value: 'dashboard',
+ label: 'dashboard',
+ customLabel: (
+ <Tooltip title={this.dashboardColorSchemeAlert}>
+ {t('Dashboard scheme')}
+ </Tooltip>
+ ),
+ },
+ ]
+ : [];
+ let currentScheme = dashboardId ? 'dashboard' : undefined;
- const allColorOptions = (isFunction(choices) ? choices() : choices).filter(
- o => o[0] !== 'SUPERSET_DEFAULT',
- );
- const options = allColorOptions.map(([value]) => ({
- value,
- label: this.schemes?.[value]?.label || value,
- customLabel: this.renderOption(value),
- }));
-
- let currentScheme =
- this.props.value ||
- (this.props.default !== undefined ? this.props.default : undefined);
-
- if (currentScheme === 'SUPERSET_DEFAULT') {
- currentScheme = this.schemes?.SUPERSET_DEFAULT?.id;
+ // if related to a dashboard the scheme is dictated by the dashboard
+ if (!dashboardId) {
+ this.schemes = isFunction(schemes) ? schemes() : schemes;
+ const controlChoices = isFunction(choices) ? choices() : choices;
+ const allColorOptions = [];
+ const filteredColorOptions = controlChoices.filter(o => {
+ const option = o[0];
+ const isValidColorOption =
+ option !== 'SUPERSET_DEFAULT' && !allColorOptions.includes(option);
+ allColorOptions.push(option);
+ return isValidColorOption;
+ });
+
+ options = filteredColorOptions.map(([value]) => ({
+ customLabel: this.renderOption(value),
+ label: this.schemes?.[value]?.label || value,
+ value,
+ }));
+
+ currentScheme =
+ this.props.value ||
+ (this.props.default !== undefined ? this.props.default : undefined);
Review comment:
Can we simplify that to `this.props.value || this.props.default`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17422:
URL: https://github.com/apache/superset/pull/17422#issuecomment-967067578
# [Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17422](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71bb1b1) into [master](https://codecov.io/gh/apache/superset/commit/ffa55f7b7fe147f945ac16935206875c5e260969?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ffa55f7) will **increase** coverage by `0.01%`.
> The diff coverage is `94.00%`.
> :exclamation: Current head 71bb1b1 differs from pull request most recent head d08d520. Consider uploading reports for the commit d08d520 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17422 +/- ##
==========================================
+ Coverage 77.01% 77.03% +0.01%
==========================================
Files 1040 1040
Lines 56077 56112 +35
Branches 7738 7750 +12
==========================================
+ Hits 43190 43224 +34
- Misses 12629 12630 +1
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.25% <94.00%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/components/controls/ColorSchemeControl/index.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wvaW5kZXguanN4) | `73.21% <90.90%> (ø)` | |
| [...dashboard/components/ColorSchemeControlWrapper.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yU2NoZW1lQ29udHJvbFdyYXBwZXIuanN4) | `81.25% <100.00%> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.23% <100.00%> (+2.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ffa55f7...d08d520](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #17422: chore: Notify user of custom label colors and related Dashboard color scheme
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #17422:
URL: https://github.com/apache/superset/pull/17422#issuecomment-967067578
# [Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17422](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4827e78) into [master](https://codecov.io/gh/apache/superset/commit/9ce6b7de839b28308d0f84e5d9abeb87d33a33a7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ce6b7d) will **increase** coverage by `0.01%`.
> The diff coverage is `93.75%`.
[](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17422 +/- ##
==========================================
+ Coverage 76.96% 76.97% +0.01%
==========================================
Files 1041 1041
Lines 56063 56096 +33
Branches 7738 7749 +11
==========================================
+ Hits 43147 43179 +32
- Misses 12658 12659 +1
Partials 258 258
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.25% <93.75%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/components/controls/ColorSchemeControl/index.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wvaW5kZXguanN4) | `72.22% <90.32%> (ø)` | |
| [...dashboard/components/ColorSchemeControlWrapper.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yU2NoZW1lQ29udHJvbFdyYXBwZXIuanN4) | `81.25% <100.00%> (ø)` | |
| [...src/dashboard/components/PropertiesModal/index.jsx](https://codecov.io/gh/apache/superset/pull/17422/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC9pbmRleC5qc3g=) | `85.23% <100.00%> (+2.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9ce6b7d...4827e78](https://codecov.io/gh/apache/superset/pull/17422?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org