You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "luthes (via GitHub)" <gi...@apache.org> on 2023/09/23 18:53:53 UTC

[GitHub] [superset] luthes opened a new pull request, #25378: fix(helm): update init containers to include extra env vars

luthes opened a new pull request, #25378:
URL: https://github.com/apache/superset/pull/25378

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   The init containers in the helm chart do not get the same environment variables as the other pods. This causes issues when the init containers attempt to ping the database, and the database variables are overridden in environment variables.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   * Add env vars to `values.yaml`, `extraEnvRaw`, or `extraEnv` example:
   ```yaml
   extraEnvRaw:
     # Load DB password from other secret (e.g. for zalando operator)
     - name: DB_PASS
       valueFrom:
         secretKeyRef:
           name: superset.superset-postgres.credentials.postgresql.acid.zalan.do
           key: password
   ```
   
   ```yaml
   extraEnv:
     GUNICORN_TIMEOUT: 300
   ```
   
   * Run `helm template superset .` 
   
   * Verify changes, in this case `deployment.yaml`, shortened for readability.
   
   With no values in `envFromRaw` or `extraEnv`:
   ```yaml
   # Source: superset/templates/deployment.yaml
   [...]
         initContainers:
         - command:
           - /bin/sh
           - -c
           - dockerize -wait "tcp://$DB_HOST:$DB_PORT" -timeout 120s
           envFrom:
           - secretRef:
               name: 'superset-test-env'
           image: 'apache/superset:dockerize'
           imagePullPolicy: 'IfNotPresent'
           name: wait-for-postgres
         containers:
   [...]
   ```
   
   With no values in `envFromRaw`, but `GUNICORN_TIMEOUT` set in `extraEnv`:
   ```yaml
   # Source: superset/templates/deployment.yaml
   [...]
         initContainers:
         - command:
           - /bin/sh
           - -c
           - dockerize -wait "tcp://$DB_HOST:$DB_PORT" -timeout 120s
           envFrom:
           - secretRef:
               name: 'superset-test-env'
           image: 'apache/superset:dockerize'
           imagePullPolicy: 'IfNotPresent'
           name: wait-for-postgres
           env:
             - name: "GUNICORN_TIMEOUT"
               value: "300"
         containers:
   [...]
   ```
   
   With `DB_PASS` set in `envFromRaw`, no values set in `extraEnv`:
   ```yaml
   [...]
         initContainers:
         - command:
           - /bin/sh
           - -c
           - dockerize -wait "tcp://$DB_HOST:$DB_PORT" -timeout 120s
           envFrom:
           - secretRef:
               name: 'superset-test-env'
           image: 'apache/superset:dockerize'
           imagePullPolicy: 'IfNotPresent'
           name: wait-for-postgres
           env:
             - name: DB_PASS
               valueFrom:
                 secretKeyRef:
                   key: password
                   name: superset.superset-postgres.credentials.postgresql.acid.zalan.do
         containers:
   [...]
   ```
   
   With both `DB_PASS` and `GUNICORN_TIMEOUT` set:
   ```yaml
   [...]
         initContainers:
         - command:
           - /bin/sh
           - -c
           - dockerize -wait "tcp://$DB_HOST:$DB_PORT" -timeout 120s
           envFrom:
           - secretRef:
               name: 'superset-test-env'
           image: 'apache/superset:dockerize'
           imagePullPolicy: 'IfNotPresent'
           name: wait-for-postgres
           env:
             - name: "GUNICORN_TIMEOUT"
               value: "300"
             - name: DB_PASS
               valueFrom:
                 secretKeyRef:
                   key: password
                   name: superset.superset-postgres.credentials.postgresql.acid.zalan.do
   
         containers:
   [...]
   ```
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes #24805
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(helm): update init containers to include extra env vars [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #25378: fix(helm): update init containers to include extra env vars
URL: https://github.com/apache/superset/pull/25378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(helm): update init containers to include extra env vars [superset]

Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #25378:
URL: https://github.com/apache/superset/pull/25378#issuecomment-1799015674

   I resolved the conflict on the Chart.yaml, however the README will need to be rebuilt as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(helm): update init containers to include extra env vars [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25378:
URL: https://github.com/apache/superset/pull/25378#issuecomment-2005091586

   Is there any interest in rekindling this, or shall we close it? I'd love to see the linked issue closed by this PR or the other one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] luthes commented on pull request #25378: fix(helm): update init containers to include extra env vars

Posted by "luthes (via GitHub)" <gi...@apache.org>.
luthes commented on PR #25378:
URL: https://github.com/apache/superset/pull/25378#issuecomment-1736354595

   This should be good to go now. Let me know if you need any further changes. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(helm): update init containers to include extra env vars [superset]

Posted by "jsvdvis (via GitHub)" <gi...@apache.org>.
jsvdvis commented on PR #25378:
URL: https://github.com/apache/superset/pull/25378#issuecomment-1798239824

   Any updates on this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(helm): update init containers to include extra env vars [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #25378:
URL: https://github.com/apache/superset/pull/25378#issuecomment-2005098176

   Actually, I'll just close this in favor of https://github.com/apache/superset/pull/27226 which seems closer to merging. Thanks for the contribution @luthes and feel free to reopen this if you want to get it across the finish line.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org