You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucy.apache.org by rectang <gi...@git.apache.org> on 2015/08/15 00:41:48 UTC
[lucy-dev] [GitHub] lucy-clownfish pull request: CLOWNFISH-59 Tune Go conversion
GitHub user rectang opened a pull request:
https://github.com/apache/lucy-clownfish/pull/35
CLOWNFISH-59 Tune Go conversion
Fix some bugs and suboptimal behaviors in the Go conversion routines.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rectang/lucy-clownfish CLOWNFISH-59-tune-go-conv
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucy-clownfish/pull/35.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #35
----
commit e2152ee531a5b7cfbaad33b12a138e91851cf7ec
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2015-08-11T19:43:39Z
Add Go binding for Obj_get_class.
commit 37aefb596c9967103fb1efb084e53da58fbd20f1
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2015-08-11T19:44:19Z
Ensure proper Go wrapper for return vals.
Access to the capabilities of a Clownfish object wrapped in a Go object
depends on the Go wrapper being class-specific. For instance, it does
not suffice to wrap a `*C.cfish_Hash` inside a `clownfish.ObjIMP`,
because you cannot invoke Hash operations on it.
Therefore, use WRAPAny for return values, so that the most specific
wrapper struct gets chosen.
commit 81ce545d140dc7bd0a1336a64c87f5c09ab961ed
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2015-08-13T02:59:01Z
Add a missing incref.
commit 8172d40724759806bba44af34e1fd2883d89e8f8
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2015-08-13T02:59:47Z
Add simple Go unwrapping function.
commit f3ed7660fb43abc67c3f7025b067115e9362517e
Author: Marvin Humphrey <ma...@rectangular.com>
Date: 2015-08-13T03:01:20Z
Handle nil args in Go method wrappers.
Parameters which have a default value of `NULL` map to a `nil` value in
Go. We can't call TOPTR() on them, so we need to use `UnwrapClownfish`.
To prevent the generated invocation statement from getting ridiculously
long, convert/unwrap *all* object types to temp variables.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[lucy-dev] [GitHub] lucy-clownfish pull request: CLOWNFISH-59 Tune Go conversion
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/lucy-clownfish/pull/35
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---