You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@subversion.apache.org by Daniel Shahaf <da...@elego.de> on 2013/07/14 20:47:49 UTC

Re: svn commit: r1502952 - /subversion/trunk/subversion/libsvn_ra_svn/client.c

rhuijben@apache.org wrote on Sun, Jul 14, 2013 at 10:31:54 -0000:
> Author: rhuijben
> Date: Sun Jul 14 10:31:53 2013
> New Revision: 1502952
> 
> URL: http://svn.apache.org/r1502952
> Log:
> Following up on r1502909, resolve error leak and introduce a wrapper function
> to allow returning the original SVN_ERR_CEASE_INVOCATION error chain.
> 

Thanks for the fix.

>        nreceived = 0;
>        if (! (limit && (nest_level == 0) && (++nreceived > limit))
> -          && ! cease_invocation)
> +          && ! *outer_error)

That's not part of your patch, but: why is NRECEIVED initialized one
line before it is incremented?  We could just change the condition to
"&& (1 > limit)" and delete NRECEIVED.