You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Alexey Kukushkin (JIRA)" <ji...@apache.org> on 2018/03/28 16:13:00 UTC

[jira] [Created] (IGNITE-8067) Java thin client code review: move parsing from TcpClientCache to ClientMessageParser

Alexey Kukushkin created IGNITE-8067:
----------------------------------------

             Summary: Java thin client code review: move parsing from TcpClientCache to ClientMessageParser
                 Key: IGNITE-8067
                 URL: https://issues.apache.org/jira/browse/IGNITE-8067
             Project: Ignite
          Issue Type: Task
          Components: thin client
    Affects Versions: 2.5
            Reporter: Alexey Kukushkin


Code review comments 9 and 10 from https://issues.apache.org/jira/browse/IGNITE-7421?focusedCommentId=16398310&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16398310 were left as technical debt due to Java thin client delivery urgency.
This task is to address:

9) {{SerDes}} - configuration serialization/deserialization is already implemented({{ClientCacheConfigurationSerializer}}). I think all we need is to implement converter from CacheConfiguration to ClientCacheConfiguration and vice versa.
10) {{ClientOperation}} and {{TcpClientCache}} - duplicates logic of {{ClientMessageParser}}. Let's simply add two new methods to decode response and encode request to this class, and remove all lambdas from {{TcpClientCache}} - we should not define the same format twice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)