You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ravi Gummadi (JIRA)" <ji...@apache.org> on 2010/04/20 11:40:41 UTC
[jira] Created: (HADOOP-6715) AccessControlList.toString() returns
empty string when we set acl to "*"
AccessControlList.toString() returns empty string when we set acl to "*"
------------------------------------------------------------------------
Key: HADOOP-6715
URL: https://issues.apache.org/jira/browse/HADOOP-6715
Project: Hadoop Common
Issue Type: Bug
Reporter: Ravi Gummadi
Assignee: Ravi Gummadi
AccessControlList.toString() returns empty string when we set the acl to "*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "*".
I think AccessControlList.toString() needs to be changed to return "*" when we set the acl to "*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6715) AccessControlList.toString() returns
empty string when we set acl to "*"
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod K V updated HADOOP-6715:
------------------------------
Status: Patch Available (was: Open)
Hadoop Flags: [Reviewed]
Patch looks good. +1.
We should commit this together with MAPREDUCE-1780 so that mapreduce doesn't get broken.
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: 6715.20S.6.patch, 6715.patch, 6715.v1.patch
>
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858798#action_12858798 ]
Hemanth Yamijala commented on HADOOP-6715:
------------------------------------------
Maybe something a little more user-friendly ? Like ALL USERS or something like that ? There is a similar, but more pertinent, display issue with empty string. There, we display an empty string, which in effect shows up as nothing. It would be nice to show something like NONE.
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "*".
> I think AccessControlList.toString() needs to be changed to return "*" when we set the acl to "*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862145#action_12862145 ]
Vinod K V commented on HADOOP-6715:
-----------------------------------
In fact more spaces between user-list and group-list makes things clearer, I think
{code}
Job-ACLs: [*]
Job-ACLs: [ ]
Job-ACLs: [ group1]
Job-ACLs: [user1,user2 group1,group2]
{code}
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863714#action_12863714 ]
Hemanth Yamijala commented on HADOOP-6715:
------------------------------------------
Yes, that's the general idea. +1 from me. You may just want to get some opinion (from users or operations folks about whether users will be confused if it says "No users are allowed", but some groups are allowed.
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6715) AccessControlList.toString() returns
empty string when we set acl to "*"
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod K V updated HADOOP-6715:
------------------------------
Component/s: security
util
I propose we separate the display functionality from {{toString()}} as the latter can potentially be used for other purposes as Ravi mentioned above. So we will
- fix {{toString()}} addressing the bug related to the wild-card '*'
- add a new API say {{AccessControlList.getDisplayString()}}. This should return "ALL USERS" for '*' and "NONE" for ' ' (empty space character) and the output of {{toString}} for every other value of ACL.
Thoughts?
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12858884#action_12858884 ]
Ravi Gummadi commented on HADOOP-6715:
--------------------------------------
Right. Would look good, if .toString() is used for displaying only.
But if .toString() is used to save it as a String and later set it to a key in some Configuration object, then "ALL USERS" will not be considered as "*" and will cause an issue ?
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "*".
> I think AccessControlList.toString() needs to be changed to return "*" when we set the acl to "*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897211#action_12897211 ]
Ravi Gummadi commented on HADOOP-6715:
--------------------------------------
Hudson didn't come back for 1 day.
I manually ran unit tests and test-patch.
All unit tests passed.
test-patch gave:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] -1 javadoc. The javadoc tool appears to have generated 1 warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
I verified that the existing javadoc warnings are not related to this patch.
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: 6715.20S.6.patch, 6715.patch, 6715.v1.patch
>
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6715) AccessControlList.toString() returns
empty string when we set acl to "*"
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated HADOOP-6715:
---------------------------------
Attachment: 6715.patch
Attaching patch for trunk.
AccessControlList.toString() returns a descriptive String of users and groups that are part of this ACL. This is same as that is there in 6715.20S.6.patch.
Also added a new public method AccessControlList.getAclString() that returns the exact String that can be used for creating a new instance of AccessControlList by passing it to the constructor.
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: 6715.20S.6.patch, 6715.patch
>
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6715) AccessControlList.toString() returns
empty string when we set acl to "*"
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated HADOOP-6715:
---------------------------------
Description:
AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
was:
AccessControlList.toString() returns empty string when we set the acl to "*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "*".
I think AccessControlList.toString() needs to be changed to return "*" when we set the acl to "*".
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897596#action_12897596 ]
Hudson commented on HADOOP-6715:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #357 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/357/])
HADOOP-6715. Fixes AccessControlList.toString() to return a descriptive String representation of the ACL. Contributed by Ravi Gummadi
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.22.0
>
> Attachments: 6715.20S.6.patch, 6715.patch, 6715.v1.patch
>
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859680#action_12859680 ]
Ravi Gummadi commented on HADOOP-6715:
--------------------------------------
Right Hemanth. People wouldn't expect toString() to give serialized string of object. We can have our own messages in it.
Will modify AccessControlList.toString() itself to give "ALL USERS" and "NONE" for "\*" and empty acl cases.
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6715) AccessControlList.toString() returns
empty string when we set acl to "*"
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated HADOOP-6715:
---------------------------------
Attachment: 6715.v1.patch
Attaching new patch for current trunk because HADOOP-6862 just got merged to trunk.
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: 6715.20S.6.patch, 6715.patch, 6715.v1.patch
>
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863693#action_12863693 ]
Vinod K V commented on HADOOP-6715:
-----------------------------------
+1. That's looks far better than anything else we considered before.
So, in summary, what we have currently
{code}
Job-ACLs:
mapreduce.job.acl-view-job: group1,group2
mapreduce.job.acl-modify-job: *
{code}
will become
{code}
Job-ACLs:
mapreduce.job.acl-view-job:
Users: No users are allowed
Groups: group1,group2
mapreduce.job.acl-modify-job:
Users: All users are allowed
Groups: All groups are allowed
{code}
Right?
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863673#action_12863673 ]
Hemanth Yamijala commented on HADOOP-6715:
------------------------------------------
We could solve the problem of All, Users, None etc being valid user names by modifying the display string. Note that this is all primarily presentation layer changes.
Firstly, I think displaying allowed users and groups separately in the UI would make it much more user friendly - rather than sticking to our internal representation.
So, we could say:
Allowed Users: a,b,c
Allowed Groups: d,e,f
When All or No users / groups have access, instead of saying:
"Users: All" or "Groups: None"
we could say
"All users can access job" or "No groups can access job"
Would this work ?
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6715) AccessControlList.toString() returns
empty string when we set acl to "*"
Posted by "Ravi Gummadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ravi Gummadi updated HADOOP-6715:
---------------------------------
Attachment: 6715.20S.6.patch
Attaching patch for earlier version of hadoop. Not for commit here.
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Attachments: 6715.20S.6.patch
>
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862144#action_12862144 ]
Vinod K V commented on HADOOP-6715:
-----------------------------------
Um.. 'ALL', 'USERS', 'NONE' can themselves be users/groups and will lead to confusions, however corner-cased they might be.
How about something simpler like the following? Essentially, I'm trying to make the space character stand out by using special chars '[' and ']' which are unlikely to end up in user/group names.
{code}
Job-ACLs: [*]
Job-ACLs: [ ]
Job-ACLs: [ group1]
Job-ACLs: [user1,user2 group1,group2]
{code}
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859303#action_12859303 ]
Hemanth Yamijala commented on HADOOP-6715:
------------------------------------------
Can one of you help me understand what Ravi means by "save it as a String and later set it to a key in some Configuration object" ? It seems like we need to store the ACL objects in some map, and possibly these need to be reconstructed from a serialized representation (like for task log access, maybe ?) and we are using the key of the map as the String that is thus serialized.
If that's the case, can we serialize the ACL using some representation that stores the actual name and value as separate fields rather than a toString representation, use a hashCode / equals on the ACL object to build a key based on these fields, and use toString for display purposes. This seems more canonical to me (inline with what toString is typically used for).
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6715) AccessControlList.toString() returns
empty string when we set acl to "*"
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-6715:
--------------------------------------------
Status: Resolved (was: Patch Available)
Fix Version/s: 0.22.0
Resolution: Fixed
I just committed this. Thanks Ravi !
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.22.0
>
> Attachments: 6715.20S.6.patch, 6715.patch, 6715.v1.patch
>
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864669#action_12864669 ]
Vinod K V commented on HADOOP-6715:
-----------------------------------
Argh.. that is confusing too.. one final jab at it:
||ACL||Message||
|user1,user2 group1,group2|Users user1,user2 and members of the groups group1,group2 are allowed|
|user1,user2 |Users user1,user2 are allowed|
| group1,group2|Members of the groups group1,group2 are allowed|
| (blank space) | No users are allowed|
|*(asterisk)| All users are allowed|
How about that? (Nothing is easy around here.. )
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6715) AccessControlList.toString()
returns empty string when we set acl to "*"
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897698#action_12897698 ]
Hudson commented on HADOOP-6715:
--------------------------------
Integrated in Hadoop-Common-trunk #422 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/422/])
HADOOP-6715. Fixes AccessControlList.toString() to return a descriptive String representation of the ACL. Contributed by Ravi Gummadi
> AccessControlList.toString() returns empty string when we set acl to "*"
> ------------------------------------------------------------------------
>
> Key: HADOOP-6715
> URL: https://issues.apache.org/jira/browse/HADOOP-6715
> Project: Hadoop Common
> Issue Type: Bug
> Components: security, util
> Reporter: Ravi Gummadi
> Assignee: Ravi Gummadi
> Fix For: 0.22.0
>
> Attachments: 6715.20S.6.patch, 6715.patch, 6715.v1.patch
>
>
> AccessControlList.toString() returns empty string when we set the acl to "\*" and also when we set it to empty(i.e. " "). This is causing wrong values for ACLs shown on jobdetails.jsp and jobdetailshistory.jsp web pages when acls are set to "\*".
> I think AccessControlList.toString() needs to be changed to return "\*" when we set the acl to "\*".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.