You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/10/17 09:19:44 UTC

[GitHub] [jena] ericprud opened a new pull request #1088: s/encodeRDFStar/encodeAsRDF/

ericprud opened a new pull request #1088:
URL: https://github.com/apache/jena/pull/1088


   As a reader, I was briefly unsure whether this no-longer-hypothetical function `RDStar.encodeRDFStar` encoded RDF-star (as RDF) or encoded RDF as RDF-star.
   This (crappy 'cause i've not looked for tests) PR changes the names to `RDFStar.encodeAsRDF` and `RDFStar.decodeFromRDF`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


[GitHub] [jena] afs commented on pull request #1088: JENA-2237: s/encodeRDFStar/encodeAsRDF/

Posted by GitBox <gi...@apache.org>.
afs commented on pull request #1088:
URL: https://github.com/apache/jena/pull/1088#issuecomment-1003745810


   Sorry - I lost track of this.
   
   JIRA: [JENA-2237](https://issues.apache.org/jira/browse/JENA-2237)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


[GitHub] [jena] ericprud commented on pull request #1088: s/encodeRDFStar/encodeAsRDF/

Posted by GitBox <gi...@apache.org>.
ericprud commented on pull request #1088:
URL: https://github.com/apache/jena/pull/1088#issuecomment-951376039


   > To me, `encodeAsRDF` is not better because it does not include "RDFStar".
   
   depends on how you write it. if you write it as `RDFStar.encodeAsRDF`, i think it's clear that you have an RDFStar object and you're encoding it as RDF.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


[GitHub] [jena] afs merged pull request #1088: JENA-2237: s/encodeRDFStar/encodeAsRDF/

Posted by GitBox <gi...@apache.org>.
afs merged pull request #1088:
URL: https://github.com/apache/jena/pull/1088


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org


[GitHub] [jena] afs commented on pull request #1088: s/encodeRDFStar/encodeAsRDF/

Posted by GitBox <gi...@apache.org>.
afs commented on pull request #1088:
URL: https://github.com/apache/jena/pull/1088#issuecomment-949425913


   Java has static imports:
   ```
   import org.apache.jena.system.RDFStar.*;
   ```
   and then the function name is used without class qualification: `encodeRDFStar`. 
   
   Eclipse, and I expect other IDEs, provide code suggestions to use this shorter form.
   
   To me, `encodeAsRDF` is not better because it does not include "RDFStar".
   
   The full name `encodeRDFStarAsRDF` is not pretty with the RDF repetition and there is the "InPlace" variant.
   
   `decodeRDFStar` could be better but it does at least pair with "encode" and include "RDFStar".
   
   The reification to RDF Star quoted triples makes an assumption that there is only one S-P-O refication so it is not a general reification to RDFStar process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org