You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2023/07/13 17:31:28 UTC

[GitHub] [trafficserver] zwoop opened a new issue, #10011: CID 1517812: Performance inefficiencies

zwoop opened a new issue, #10011:
URL: https://github.com/apache/trafficserver/issues/10011

   ```
   *** CID 1517812:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
   /iocore/net/[UnixUDPNet.cc](http://unixudpnet.cc/): 97 in UDPPacket::new_incoming_UDPPacket(sockaddr *, sockaddr *, Ptr<IOBufferBlock>)()
   91     
   92       p->p.in_the_priority_queue = 0;
   93       p->p.in_heap               = 0;
   94       p->p.delivery_time         = 0;
   95       ats_ip_copy(&p->from, from);
   96       ats_ip_copy(&p->to, to);
      CID 1517812:  Performance inefficiencies  (COPY_INSTEAD_OF_MOVE)
      "block" is copied in a call to copy assignment "operator =", when it could be moved instead.
   97       p->p.chain = block;
   98     
   99       return p;
   100     }
   101     
   102     UDPPacket::UDPPacket()
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] CID 1517812: Performance inefficiencies [trafficserver]

Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit closed issue #10011: CID 1517812:  Performance inefficiencies
URL: https://github.com/apache/trafficserver/issues/10011


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] JosiahWI commented on issue #10011: CID 1517812: Performance inefficiencies

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on issue #10011:
URL: https://github.com/apache/trafficserver/issues/10011#issuecomment-1634816391

   Sorry, looked at that and that wasn't the issue. It was #9905. The pointer was passed by reference and now it's passed by value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] zwoop commented on issue #10011: CID 1517812: Performance inefficiencies

Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on issue #10011:
URL: https://github.com/apache/trafficserver/issues/10011#issuecomment-1634693428

   Making a bit of a guess, but this may be coming in from #9905 or #9869.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] brbzull0 commented on issue #10011: CID 1517812: Performance inefficiencies

Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on issue #10011:
URL: https://github.com/apache/trafficserver/issues/10011#issuecomment-1721052436

   Just saw this. will take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] brbzull0 commented on issue #10011: CID 1517812: Performance inefficiencies

Posted by "brbzull0 (via GitHub)" <gi...@apache.org>.
brbzull0 commented on issue #10011:
URL: https://github.com/apache/trafficserver/issues/10011#issuecomment-1721051369

   I'll take care of this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficserver] JosiahWI commented on issue #10011: CID 1517812: Performance inefficiencies

Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on issue #10011:
URL: https://github.com/apache/trafficserver/issues/10011#issuecomment-1634814985

   I took a look at it, and it looks like this was directly introduced by #9413.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org