You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Yee-wah Lee <ye...@oracle.com> on 2007/09/22 01:11:44 UTC

[Trinidad] time-zone in trinidad-config.xml, case sensitive?

Hi everyone,

I have questions about how we should handle parsing the <time-zone> 
parameter in trinidad-config.xml.

I see that we do this:
org.apache.myfaces.trinidadinternal.config.ConfigParser.java
            else if (key.getType() == TimeZone.class)
            {
              value = TimeZone.getTimeZone(_currentText);
            }

If the user enters the wrong case for the timezoneID, e.g. 
"america/new_york" instead of "America/New_York", the code would return 
the following:
Windows: Returns a ZoneInfo object with correct offsets, but ID = 
"america/new_york"
Unix/Linux: Returns GMT TimeZone

Should we make the parser more lenient and resolve the timezone 
correctly in this case? Or,  just log a warning if the return TimeZone's 
getID() doesn't match the param value?

FWIW, in the same file, I see both examples. Boolean keys are parsed 
case-insensitively but Enums are logged if Enum.valueOf(..) fails.

Thanks,
Yee-Wah