You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Amruta Borkar <ar...@us.ibm.com> on 2017/02/02 20:01:26 UTC
Review Request 56235: findLatestServiceConfigsByStack query returns
deleted config group
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56235/
-----------------------------------------------------------
Review request for Ambari, Di Li and Nate Cole.
Bugs: AMBARI-19813
https://issues.apache.org/jira/browse/AMBARI-19813
Repository: ambari
Description
-------
Query returns deleted config groups as latest active config group.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java 8a1b316
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java 5890c35
Diff: https://reviews.apache.org/r/56235/diff/
Testing
-------
Modified test cases.
Thanks,
Amruta Borkar
Re: Review Request 56235: findLatestServiceConfigsByStack query
returns deleted config group
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56235/#review164135
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Feb. 2, 2017, 8:01 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56235/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 8:01 p.m.)
>
>
> Review request for Ambari, Di Li and Nate Cole.
>
>
> Bugs: AMBARI-19813
> https://issues.apache.org/jira/browse/AMBARI-19813
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Query returns deleted config groups as latest active config group.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java 8a1b316
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java 5890c35
>
> Diff: https://reviews.apache.org/r/56235/diff/
>
>
> Testing
> -------
>
> Modified test cases.
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 56235: findLatestServiceConfigsByStack query
returns deleted config group
Posted by Amruta Borkar <ar...@us.ibm.com>.
> On Feb. 3, 2017, 1:28 p.m., Di Li wrote:
> > Ship It!
>
> Di Li wrote:
> pushed to trunk as https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=ecfc951b5c8589b9225684c3ad2660cdb4ef4445
Thank you Di.
- Amruta
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56235/#review164118
-----------------------------------------------------------
On Feb. 2, 2017, 8:01 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56235/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 8:01 p.m.)
>
>
> Review request for Ambari, Di Li and Nate Cole.
>
>
> Bugs: AMBARI-19813
> https://issues.apache.org/jira/browse/AMBARI-19813
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Query returns deleted config groups as latest active config group.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java 8a1b316
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java 5890c35
>
> Diff: https://reviews.apache.org/r/56235/diff/
>
>
> Testing
> -------
>
> Modified test cases.
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 56235: findLatestServiceConfigsByStack query
returns deleted config group
Posted by Di Li <di...@ca.ibm.com>.
> On Feb. 3, 2017, 1:28 p.m., Di Li wrote:
> > Ship It!
pushed to trunk as https://git-wip-us.apache.org/repos/asf?p=ambari.git;a=commit;h=ecfc951b5c8589b9225684c3ad2660cdb4ef4445
- Di
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56235/#review164118
-----------------------------------------------------------
On Feb. 2, 2017, 8:01 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56235/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 8:01 p.m.)
>
>
> Review request for Ambari, Di Li and Nate Cole.
>
>
> Bugs: AMBARI-19813
> https://issues.apache.org/jira/browse/AMBARI-19813
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Query returns deleted config groups as latest active config group.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java 8a1b316
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java 5890c35
>
> Diff: https://reviews.apache.org/r/56235/diff/
>
>
> Testing
> -------
>
> Modified test cases.
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 56235: findLatestServiceConfigsByStack query
returns deleted config group
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56235/#review164118
-----------------------------------------------------------
Ship it!
Ship It!
- Di Li
On Feb. 2, 2017, 8:01 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56235/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 8:01 p.m.)
>
>
> Review request for Ambari, Di Li and Nate Cole.
>
>
> Bugs: AMBARI-19813
> https://issues.apache.org/jira/browse/AMBARI-19813
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Query returns deleted config groups as latest active config group.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java 8a1b316
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java 5890c35
>
> Diff: https://reviews.apache.org/r/56235/diff/
>
>
> Testing
> -------
>
> Modified test cases.
>
>
> Thanks,
>
> Amruta Borkar
>
>
Re: Review Request 56235: findLatestServiceConfigsByStack query
returns deleted config group
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56235/#review164018
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Feb. 2, 2017, 3:01 p.m., Amruta Borkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56235/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2017, 3:01 p.m.)
>
>
> Review request for Ambari, Di Li and Nate Cole.
>
>
> Bugs: AMBARI-19813
> https://issues.apache.org/jira/browse/AMBARI-19813
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Query returns deleted config groups as latest active config group.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceConfigEntity.java 8a1b316
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/ServiceConfigDAOTest.java 5890c35
>
> Diff: https://reviews.apache.org/r/56235/diff/
>
>
> Testing
> -------
>
> Modified test cases.
>
>
> Thanks,
>
> Amruta Borkar
>
>