You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/02/03 01:19:24 UTC

[GitHub] [logging-log4j2] carterkozak commented on pull request #542: LOG4J2-2785: Added support for pattern Layout to abbreviate logger or class names except n rightmost words

carterkozak commented on pull request #542:
URL: https://github.com/apache/logging-log4j2/pull/542#issuecomment-1028513533


   @sman-81 we are all volunteers and have limited time to devote to review. Your most recent comment comes across as entitled and rude. Please work on that. In your position, I might have replied on the PR with "Is there anything I can do to get this into a mergable state?"
   
   > you listen to their criticism
   > you incorporate their feedback
   
   I asked you twice to avoid `string.split` in favor of `indexOf`/`lastIndexOf`, but it's still used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org