[java] Potential bug in AMQSession.java close method

[Rajith Attapattu <ra...@gmail.com>]

When the session.close() is invoked it will in turn call the "private void
closeConsumers(Throwable error) throws JMSException"  method.
In this method if the error is null then the consumer.close method is called
with "sendClose=false".

I wonder if this is the correct setting. I suspect the intended value is
"true".
I am not sure why we are not going to send a message cancel in this case.

Does anybody know the reasons behind the above decision ?
Is this a bug ?

Regards,

Rajith

Re: [java] Potential bug in AMQSession.java close method

[Rajith Attapattu <ra...@gmail.com>]

I am actually tempted to change it to 'True'  and see how the tests work out.
Would there be any objections if I make the change provided there are
no test failures ?

Rajith

On Thu, Apr 7, 2011 at 9:59 AM, Robbie Gemmell <ro...@gmail.com> wrote:
> No idea about the decision, long before my time. From your description it
> does sound like it should be true.
>
> Robbie
>
> On 5 April 2011 20:17, Rajith Attapattu <ra...@gmail.com> wrote:
>
>> When the session.close() is invoked it will in turn call the "private void
>> closeConsumers(Throwable error) throws JMSException"  method.
>> In this method if the error is null then the consumer.close method is
>> called
>> with "sendClose=false".
>>
>> I wonder if this is the correct setting. I suspect the intended value is
>> "true".
>> I am not sure why we are not going to send a message cancel in this case.
>>
>> Does anybody know the reasons behind the above decision ?
>> Is this a bug ?
>>
>> Regards,
>>
>> Rajith
>>
>

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org

Re: [java] Potential bug in AMQSession.java close method

[Robbie Gemmell <ro...@gmail.com>]

No idea about the decision, long before my time. From your description it
does sound like it should be true.

Robbie

On 5 April 2011 20:17, Rajith Attapattu <ra...@gmail.com> wrote:

> When the session.close() is invoked it will in turn call the "private void
> closeConsumers(Throwable error) throws JMSException"  method.
> In this method if the error is null then the consumer.close method is
> called
> with "sendClose=false".
>
> I wonder if this is the correct setting. I suspect the intended value is
> "true".
> I am not sure why we are not going to send a message cancel in this case.
>
> Does anybody know the reasons behind the above decision ?
> Is this a bug ?
>
> Regards,
>
> Rajith
>