You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ace.apache.org by ja...@apache.org on 2012/04/26 13:31:52 UTC

svn commit: r1330782 - in /ace/trunk: ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/impl/ ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/stateful/impl/ ace-deployment-provider-repositorybased/src/m...

Author: jawi
Date: Thu Apr 26 11:31:52 2012
New Revision: 1330782

URL: http://svn.apache.org/viewvc?rev=1330782&view=rev
Log:
Fixed some logging statements and incorrect chaining of exceptions.

Modified:
    ace/trunk/ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/impl/ObjectRepositoryImpl.java
    ace/trunk/ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/stateful/impl/StatefulTargetObjectImpl.java
    ace/trunk/ace-deployment-provider-repositorybased/src/main/java/org/apache/ace/deployment/provider/repositorybased/RepositoryBasedProvider.java

Modified: ace/trunk/ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/impl/ObjectRepositoryImpl.java
URL: http://svn.apache.org/viewvc/ace/trunk/ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/impl/ObjectRepositoryImpl.java?rev=1330782&r1=1330781&r2=1330782&view=diff
==============================================================================
--- ace/trunk/ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/impl/ObjectRepositoryImpl.java (original)
+++ ace/trunk/ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/impl/ObjectRepositoryImpl.java Thu Apr 26 11:31:52 2012
@@ -80,7 +80,7 @@ abstract class ObjectRepositoryImpl<I ex
         if (add(result)) {
             return result;
         }
-        throw new IllegalArgumentException();
+        throw new IllegalArgumentException("Failed to add new object: entity already exists!");
     }
 
     /**

Modified: ace/trunk/ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/stateful/impl/StatefulTargetObjectImpl.java
URL: http://svn.apache.org/viewvc/ace/trunk/ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/stateful/impl/StatefulTargetObjectImpl.java?rev=1330782&r1=1330781&r2=1330782&view=diff
==============================================================================
--- ace/trunk/ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/stateful/impl/StatefulTargetObjectImpl.java (original)
+++ ace/trunk/ace-client-repository-impl/src/main/java/org/apache/ace/client/repository/stateful/impl/StatefulTargetObjectImpl.java Thu Apr 26 11:31:52 2012
@@ -81,7 +81,7 @@ public class StatefulTargetObjectImpl im
             return version;
         }
         catch (IOException e) {
-            throw new IllegalStateException("Problem generating new deployment version: " + e);
+            throw new IllegalStateException("Problem generating new deployment version: " + e.getMessage(), e);
         }
     }
 

Modified: ace/trunk/ace-deployment-provider-repositorybased/src/main/java/org/apache/ace/deployment/provider/repositorybased/RepositoryBasedProvider.java
URL: http://svn.apache.org/viewvc/ace/trunk/ace-deployment-provider-repositorybased/src/main/java/org/apache/ace/deployment/provider/repositorybased/RepositoryBasedProvider.java?rev=1330782&r1=1330781&r2=1330782&view=diff
==============================================================================
--- ace/trunk/ace-deployment-provider-repositorybased/src/main/java/org/apache/ace/deployment/provider/repositorybased/RepositoryBasedProvider.java (original)
+++ ace/trunk/ace-deployment-provider-repositorybased/src/main/java/org/apache/ace/deployment/provider/repositorybased/RepositoryBasedProvider.java Thu Apr 26 11:31:52 2012
@@ -204,7 +204,8 @@ public class RepositoryBasedProvider imp
             }
         }
 
-        System.out.println("Cache added: " + targetId);
+        m_log.log(LogService.LOG_DEBUG, "Cache added for " + targetId);
+
         m_cachedVersionLists.put(targetId, stringVersionList);
         return stringVersionList;
     }