You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/11/15 07:40:46 UTC
[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14712
Change subject: [mini_cluster] SetDaemonFlag for test minicluster
......................................................................
[mini_cluster] SetDaemonFlag for test minicluster
Added control to call SetFlag() RPC on masters and tablet servers
via mini_cluster test interface. Also, added a test to cover the
new functionality.
Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
4 files changed, 92 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/14712/1
--
To view, visit http://gerrit.cloudera.org:8080/14712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Gerrit-Change-Number: 14712
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14712 )
Change subject: [mini_cluster] SetDaemonFlag for test minicluster
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14712/1/src/kudu/tools/tool_action_test.cc
File src/kudu/tools/tool_action_test.cc:
http://gerrit.cloudera.org:8080/#/c/14712/1/src/kudu/tools/tool_action_test.cc@299
PS1, Line 299: RETURN_NOT_OK(Status::InvalidArgument("cannot find daemon at "));
This implies we landed on the KDC, right? Maybe we should just say something like that?
Also don't need RETURN_NOT_OK here.
--
To view, visit http://gerrit.cloudera.org:8080/14712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Gerrit-Change-Number: 14712
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 Nov 2019 22:36:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14712 )
Change subject: [mini_cluster] SetDaemonFlag for test minicluster
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Gerrit-Change-Number: 14712
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 16 Nov 2019 00:42:05 +0000
Gerrit-HasComments: No
[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14712 )
Change subject: [mini_cluster] SetDaemonFlag for test minicluster
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14712/1/src/kudu/tools/tool_action_test.cc
File src/kudu/tools/tool_action_test.cc:
http://gerrit.cloudera.org:8080/#/c/14712/1/src/kudu/tools/tool_action_test.cc@299
PS1, Line 299: ExternalDaemon* daemon;
> This implies we landed on the KDC, right? Maybe we should just say somethin
Done
--
To view, visit http://gerrit.cloudera.org:8080/14712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Gerrit-Change-Number: 14712
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 15 Nov 2019 23:53:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14712 )
Change subject: [mini_cluster] SetDaemonFlag for test minicluster
......................................................................
[mini_cluster] SetDaemonFlag for test minicluster
Added control knobs to call SetFlag() RPC on masters and tablet servers
via mini_cluster test interface. Also, added a test to cover the
new functionality.
Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Reviewed-on: http://gerrit.cloudera.org:8080/14712
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
4 files changed, 130 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Gerrit-Change-Number: 14712
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [mini cluster] SetDaemonFlag for test minicluster
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14712
to look at the new patch set (#2).
Change subject: [mini_cluster] SetDaemonFlag for test minicluster
......................................................................
[mini_cluster] SetDaemonFlag for test minicluster
Added control knobs to call SetFlag() RPC on masters and tablet servers
via mini_cluster test interface. Also, added a test to cover the
new functionality.
Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
---
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
4 files changed, 130 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/14712/2
--
To view, visit http://gerrit.cloudera.org:8080/14712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie05aa87bba1b709cbbab953b6b220cae0fc958bb
Gerrit-Change-Number: 14712
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)