[I] [C++][Gandiva] default cache size is incorrect and too small [arrow]

["niyue (via GitHub)" <gi...@apache.org>]

niyue opened a new issue, #40040:
URL: https://github.com/apache/arrow/issues/40040

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   The default cache size of Gandiva is 500 by default, and this value was set for LLVM module based cache (which took larger memory size) and is too small for the current object code cache.
   
   This part was changed several times, and the history is like this:
   1. https://issues.apache.org/jira/browse/ARROW-15514, Add flag to enable Gandiva Object Code
     * https://github.com/apache/arrow/issues/30987, the PR added a macro called `GANDIVA_ENABLE_OBJECT_CODE_CACHE` to enable object code cache conditionally during build time
   2. https://issues.apache.org/jira/browse/ARROW-15648, Fix the size of the Gandiva cache
     * https://github.com/apache/arrow/pull/12394, this PR added a new default `DEFAULT_CACHE_SIZE` whose value is `500000`, and is only enabled when the `GANDIVA_ENABLE_OBJECT_CODE_CACHE` is enabled during build time
   3. https://issues.apache.org/jira/browse/ARROW-16055,  Fix the performance hit in queries when enabling object code cache in gandiva
     * https://github.com/apache/arrow/pull/12742, this PR removed the `GANDIVA_ENABLE_OBJECT_CODE_CACHE` flag and made object code cache as default. However, the default cache size's flag was not removed, which is unexpected
   
   
   ### Component(s)
   
   C++ - Gandiva


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [C++][Gandiva] default cache size is incorrect and too small [arrow]

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou closed issue #40040: [C++][Gandiva] default cache size is incorrect and too small
URL: https://github.com/apache/arrow/issues/40040


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org