[GitHub] [incubator-kyuubi] ulysses-you commented on a diff in pull request #2477: Change state early on stopping

[GitBox <gi...@apache.org>]

ulysses-you commented on code in PR #2477:
URL: https://github.com/apache/incubator-kyuubi/pull/2477#discussion_r858166250


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -48,8 +48,8 @@ case class SparkSQLEngine(spark: SparkSession) extends Serverable("SparkSQLEngin
   override val backendService = new SparkSQLBackendService(spark)
   override val frontendServices = Seq(new SparkTBinaryFrontendService(this))
 
-  @volatile private var shutdown = false
-  @volatile private var deregistered = false
+  private val shutdown = new AtomicBoolean(false)
+  private val deregistered = new AtomicBoolean(false)

Review Comment:
   as we are here, we can move `deregistered` inside `startLifetimeTerminatingChecker`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org