You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/13 02:41:28 UTC

[GitHub] [arrow] liyafan82 commented on pull request #8605: ARROW-10508 [Java] Allow FixedSizeListVector to have empty children

liyafan82 commented on pull request #8605:
URL: https://github.com/apache/arrow/pull/8605#issuecomment-726470885


   > @liyafan82 good idea, added test case to PR.
   > Also tested together with C++ in my demo project: [commit](https://github.com/Kopilov/Arrow_FixedSizeListVector_ZeroWidth/commit/3c2935382c6eed891844f7c4100b4bf5d7037646), [workflow](https://github.com/Kopilov/Arrow_FixedSizeListVector_ZeroWidth/runs/1391351598).
   > Everything looks like OK
   
   @Kopilov Thanks for your follow-up.
   
   The new test case `testVectorWithNulls` is nice to have.
   What I meant was that maybe we need a null slot in the list vector, and test our vector correctly distinguishes between an empty array and a null (sorry I did not made this clear enough)
   I've prepared a commit for that. Could you please check?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org