[GitHub] [druid] zachjsh commented on a change in pull request #9525: Azure deep storage does not work with datasource name containing non-ASCII chars

[GitBox <gi...@apache.org>]

zachjsh commented on a change in pull request #9525: Azure deep storage does not work with datasource name containing non-ASCII chars
URL: https://github.com/apache/druid/pull/9525#discussion_r394831357
 
 

 ##########
 File path: extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureDataSegmentPusher.java
 ##########
 @@ -186,12 +186,24 @@ DataSegment uploadDataSegment(
 
     final DataSegment outSegment = segment
         .withSize(size)
-        .withLoadSpec(this.makeLoadSpec(new URI(azurePath)))
+        .withLoadSpec(this.makeLoadSpec(segmentConfig.getContainer(), azurePath))
         .withBinaryVersion(binaryVersion);
 
     log.debug("Deleting file [%s]", compressedSegmentData);
     compressedSegmentData.delete();
 
     return outSegment;
   }
+
+  private Map<String, Object> makeLoadSpec(String container, String prefix)
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org