[jira] [Commented] (SOLR-12313) TestInjection#waitForInSyncWithLeader needs improvement.

["Mark Miller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-12313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464501#comment-16464501 ] 

Mark Miller commented on SOLR-12313:
------------------------------------

I have to dig into this more to understand why this was sometimes slowing things up so much or not passing when it should (main reason I saw for that was when replication things things are in sync, but this check does not). The description is just a dump from weird stuff I was seeing in the middle of the night.

Given that it's injected for all commits in every test randomly it looks, we want to make sure it's not slowing up tests in certain cases when it should not, or taking the full timeout for legit cases.

> TestInjection#waitForInSyncWithLeader needs improvement.
> --------------------------------------------------------
>
>                 Key: SOLR-12313
>                 URL: https://issues.apache.org/jira/browse/SOLR-12313
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Priority: Major
>
> This really should have some doc for why it would be used.
> I also think it causes BasicDistributedZkTest to take forever for sometimes and perhaps other tests?
> I think checking for uncommitted data is probably a race condition and should be removed.
> Checking index versions should follow the rules that replication does - if the slave is higher than the leader, it's in sync, being equal is not required. If it's expected for a test it should be a specific test that fails. This just introduces massive delays.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org