You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by rakatyal <gi...@git.apache.org> on 2016/02/18 23:40:19 UTC

[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

GitHub user rakatyal opened a pull request:

    https://github.com/apache/cordova-docs/pull/507

    CB-10336: Adding platform and plugin guides and other articles to TOC

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-docs raghav-toc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-docs/pull/507.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #507
    
----
commit 8c884767dfd017576a32e15b14ffa088a017cc96
Author: Raghav Katyal <ra...@microsoft.com>
Date:   2016-02-18T22:30:23Z

    Adding platform and plugin guides and other articles to TOC

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:

    https://github.com/apache/cordova-docs/pull/507#issuecomment-185978070
  
    LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/507#discussion_r53396702
  
    --- Diff: www/_data/toc/de-dev-manual.yml ---
    @@ -1,21 +1,37 @@
    --   name: "Overview"
    -    url: "guide/overview/index.html"
    -# -   name: "Architecture"
    -#     children:
    -#         -   name: "Runtime Architecture"
    -#             url:
    -#         -   name: "Tooling Architecture"
    -#             url:
    +-   name: "Introduction"
    +    children:
    +        -   name: "Overview"
    +            url: "guide/overview/index.html"
    +#       -   name: "Runtime Architecture"
    +#           url:
    +#       -   name: "Tooling Architecture"
    +#           url:
     -   name: "Create apps"
         children:
             -   name: "Create your first app"
                 url:
    +        -   name: "Platform support"
    +            url: "guide/support/index.html"
             -   name: "Develop for platforms"
    -            url: "guide/platforms/index.html"
    +            children:
    +                -   name: "Android"
    +                    url: "guide/platforms/android/index.html"
    +                -   name: "Blackberry 10"
    +                    url: "guide/platforms/blackberry10/home.html"
    +                -   name: "iOS"
    +                    url: "guide/platforms/ios/index.html"
    +                -   name: "Ubuntu"
    +                    url: "guide/platforms/ubuntu/index.html"
    +                -   name: "Windows"
    +                    url: "guide/platforms/win8/index.html"
    +                -   name: "WP8"
    +                    url: "guide/platforms/wp8/home.html"                                                           
    --- End diff --
    
    Is OS X supposed to be in this list, or has that content not made it in yet?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/507#discussion_r53397157
  
    --- Diff: www/_data/toc/de-dev-manual.yml ---
    @@ -1,21 +1,37 @@
    --   name: "Overview"
    -    url: "guide/overview/index.html"
    -# -   name: "Architecture"
    -#     children:
    -#         -   name: "Runtime Architecture"
    -#             url:
    -#         -   name: "Tooling Architecture"
    -#             url:
    +-   name: "Introduction"
    +    children:
    +        -   name: "Overview"
    +            url: "guide/overview/index.html"
    +#       -   name: "Runtime Architecture"
    +#           url:
    +#       -   name: "Tooling Architecture"
    +#           url:
     -   name: "Create apps"
         children:
             -   name: "Create your first app"
                 url:
    +        -   name: "Platform support"
    +            url: "guide/support/index.html"
             -   name: "Develop for platforms"
    -            url: "guide/platforms/index.html"
    +            children:
    +                -   name: "Android"
    +                    url: "guide/platforms/android/index.html"
    +                -   name: "Blackberry 10"
    +                    url: "guide/platforms/blackberry10/home.html"
    +                -   name: "iOS"
    +                    url: "guide/platforms/ios/index.html"
    +                -   name: "Ubuntu"
    +                    url: "guide/platforms/ubuntu/index.html"
    +                -   name: "Windows"
    +                    url: "guide/platforms/win8/index.html"
    +                -   name: "WP8"
    +                    url: "guide/platforms/wp8/home.html"                                                           
    --- End diff --
    
    That's still in PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal commented on the pull request:

    https://github.com/apache/cordova-docs/pull/507#issuecomment-185996114
  
    Merged [here](https://github.com/apache/cordova-docs/commit/f8e4b8b8ee0c9f0a8afef27a7d9a9c48b9274d36).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-docs pull request: CB-10336: Adding platform and plugin gu...

Posted by rakatyal <gi...@git.apache.org>.
Github user rakatyal closed the pull request at:

    https://github.com/apache/cordova-docs/pull/507


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org