[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1372: MINIFICPP-1884 Make whitespaces consistent across cmake files

[GitBox <gi...@apache.org>]

lordgamez commented on code in PR #1372:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1372#discussion_r923326495


##########
CMakeLists.txt:
##########
@@ -68,8 +68,8 @@ option(USE_REAL_ODBC_TEST_DRIVER "Use SQLite ODBC driver in SQL extenstion unit
 # different than "GNU Makefiles".
 option (FORCE_COLORED_OUTPUT "Always produce ANSI-colored output (GNU/Clang only)." FALSE)
 option(AWS_ENABLE_UNITY_BUILD "If enabled, AWS SDK libraries will be built as a single, generated .cpp file. \
-	This can significantly reduce static library size as well as speed up a single compilation time, but it is regenerated \
-	and recompiled in every iterative build instance. Turn off to avoid recompilation." ON)
+  This can significantly reduce static library size as well as speed up a single compilation time, but it is regenerated \
+  and recompiled in every iterative build instance. Turn off to avoid recompilation." ON)

Review Comment:
   I was not aware of this, should this be the same for parameters as well? Like in cmake/BundledOpenCV.cmake `set` parameters are wrapped differently with either 1 or 2 indentations in new lines.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org